You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I reviewed the agreed direction in #3083 and the follow-up #3208. Both PRs were closed automatically as stale and there is no open successor, so I prepared a narrow refreshed branch for the first slice: keep the existing Config() API, defer configuration-file and environment reads until the first config/get_* access, and cache the merged result per instance. It does not move _ENV_CONFIG or change the catalog-loading API.
Activity
kevinjqliu commentedon Mar 17, 2026
Should
_ENV_CONFIGeven exist? its only used inload_catalogandlist_catalogsIf we want
Config()to be cached, maybe it should be in config.pyWe should still make it lazy and not loaded automatically on import
We might want to replace all calls to
Config()in the codebase with the cached version, so that we wont need to re-parse everytimeemecii commentedon Sep 10, 2026
I reviewed the agreed direction in #3083 and the follow-up #3208. Both PRs were closed automatically as stale and there is no open successor, so I prepared a narrow refreshed branch for the first slice: keep the existing
Config()API, defer configuration-file and environment reads until the firstconfig/get_*access, and cache the merged result per instance. It does not move_ENV_CONFIGor change the catalog-loading API.The branch is https://github.com/emecii/iceberg-python/tree/refactor/lazy-config-loading at
5586c286. On currentmain, the full unit target passes (4,019 passed, 3 skipped), as domake lintand Apache RAT on a clean worktree.@jx2lee @kevinjqliu, is it okay for me to open this narrow PR, or would you prefer the earlier work to be revived/continued instead?
OpenAI Codex generated the patch, tests, and this comment and ran the reported checks. No human review is asserted.