Repository navigation
Conversation
- add migration path to the warning to make it more useful for platform or plugin developers - 'nb.disable.editorkit.hack' can now be used to disable the kit injection including the warning - the default value of the flag will be set true in future first, before subsequent removal of the code
lahodaj
left a comment
lahodaj
left a comment
There was a problem hiding this comment.
Looks good to me. For the next release, we should change the setting to true/disable; and maybe think of adding a Jackpot rule.
|
yep. thought about a jackpot rule too. but one constructor usage as no direct match i believe (still useful). |
neilcsmith-net
left a comment
neilcsmith-net
left a comment
There was a problem hiding this comment.
Looks good. Hopefully not too noisy in IDE usage.
Jackpot rule might be hard to get correct, as some usages are legitimate (built-ins). And the other fix is for people to register using JEditorPane::registerEditorKitForContentType as in the removed comment. That could be done in a module installer instead.
I assume the reason that the commented code was never used is that it can't handle lazy registration. The other fix here might be to listen on lookup for EditorKit availability and register using the proper Swing API. Given we're unlikely to do that for NB32 though, it's probably better to just assume removal of this feature.
there is also the option to write the hint in java. There are some platform specific hints already. but we would have to know what it should suggest, e.g the html mime type didn't work when I tried #9713 (comment) |
3 participants
nb.disable.editorkit.hackcan now be used to disable the kit injection including the warningmeta #9523
targets delivery