Repository navigation
Conversation
matthiasblaesing
left a comment
matthiasblaesing
left a comment
Contributor
There was a problem hiding this comment.
The generate idea makes sense, but please lets not use string replacement to modify XML. This asks for trouble the moment people how something more exotic in their path than ascii characters. The minimum problematic set are &, ", ', < and >, maybe even more when RAT writes entities.
We have the full power of the JVM at our disposal, so lets use it.
Please have a look here: matthiasblaesing@15fd667. Feel free to squash that if you agree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a few changes to rat processing for NetBeans
will anable rat again for rc2