Repository navigation
[Python] Avoid unused tensor conversions in LeRobot windows - #10704
Merged
JingsongLi merged 1 commit intoOct 21, 2026
Merged
JingsongLi merged 1 commit into
JingsongLi merged 1 commit into
Conversation
XiaoHongbo-Hope
marked this pull request as ready for review
October 21, 2026 04:23
XiaoHongbo-Hope
force-pushed
the
python-lerobot-window-feature-conversion
branch
from
October 21, 2026 06:06
7d9a444 to
99055c6
Compare
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
LeRobot temporal windows load auxiliary frames alongside each requested sample. These auxiliary rows currently convert control fields such as
indexandtimestampto tensors even when only their State/Action or image features are used.Convert only the requested window features for auxiliary rows. Base samples retain all fields, explicitly requested control-field windows still work, and all rows undergo the existing metadata validation.
Three paired prototype runs on #10701 with public
lerobot/pusht: 4,996 → 5,478 samples/s (+9.6%), with average PSS essentially unchanged at 3.20 GiB. Local warm-cache CPU decoding, batch 32, 8 workers, 8-frame windows, uint8, no transforms/model; 10 warmup + 500 measured batches. Same-run official Lance achieved 6,091 samples/s. These are diagnostic prototype measurements, not a benchmark of this PR head.Tests
git diff --checkpassed.