Repository navigation
[python] Fix bucket registration for dynamic bucket overflow - #9788
Merged
Merged
Conversation
Register each bucket when it is selected as a new bucket. Previously, later buckets received count entries before registration, leaving only the first bucket eligible for overflow assignment. Add regression coverage for complete, duplicate-free candidates and stable existing hash mappings. Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
JingsongLi
reviewed
Sep 14, 2026
JingsongLi
left a comment
JingsongLi
left a comment
Contributor
There was a problem hiding this comment.
Reviewed d261f98. Requirement fit: SUPPORTED. Implementation: CLEAN.
The registration move fixes a reachable write imbalance: after allocating several dynamic buckets and reaching the configured cap, the old candidate list contained only the first bucket, so new keys accumulated there. Registering at allocation preserves the complete candidate set while existing hash-to-bucket mappings remain stable.
The exact-head simple assigner and dynamic-bucket suites passed locally: 26 tests, including all-candidate overflow and repeated-key checks. Current CI is also successful. No blocking issue found.
XiaoHongbo-Hope
pushed a commit
that referenced
this pull request
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Follow-up on #7363. Newly allocated buckets received count entries before candidate registration, causing registration to be skipped. Once the bucket limit was reached, only the first bucket remained eligible for random assignment.
Register each bucket when it is allocated, keeping candidates complete and duplicate-free while preserving the random selection strategy and existing hash mappings.
Tests