Repository navigation
Conversation
Backport apache#3830. Keep component paths in dictionary metadata and cache keys to avoid collisions between dotted and nested column names. (cherry picked from commit bca2eae) Co-authored-by: Codex <codex@openai.com>
wgtmac
approved these changes
Oct 21, 2026
divjotarora
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Backport #3830 to
parquet-1.18.xto prevent dictionary lookup collisions between literal dotted names and nested column paths.What changes are included in this PR?
Cherry-picks
bca2eaea, retainingColumnPathkeys for dictionary metadata and caches plus the upstream regression.Are these changes tested?
Passed: Java 17 / Thrift 0.23.0 focused reactor verification for
TestParquetWriter(32 tests, 0 skipped); Spotless andgit diff --check. Broad integration tests and Javadocs were skipped.Are there any user-facing changes?
Dictionary pruning uses the correct column dictionary for colliding dot-string paths. No file-format change.