Repository navigation
GH-3487: [1.18.x] Release sequential row-group buffers - #3874
Merged
wgtmac merged 1 commit intoOct 21, 2026
Merged
Conversation
Backport apache#3488 and its JUnit 5 test correction from apache#3774 (a363f5d). Close the prior sequential row-group store on advance and the final store on reader close. (cherry picked from commit 5702bae) Co-authored-by: Bodor Laszlo <bodorlaszlo0202@gmail.com> Co-authored-by: Codex <codex@openai.com>
wgtmac
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Backport #3488 to
parquet-1.18.xto balance row-group buffer releases for directParquetFileReadercallers.What changes are included in this PR?
Cherry-picks
5702baeeand the JUnit 5 test correction from #3774 (a363f5da). Production behavior matches #3488.Are these changes tested?
Passed: Java 17 / Thrift 0.23.0 focused reactor verification for
TestParquetFileReaderBufferLeak,TestColumnChunkPageReadStore,TestParquetReader,TestParquetFileReaderRowRanges, andTestColumnIndexFiltering(63 tests, 0 skipped); Spotless andgit diff --check. Broad integration tests and Javadocs were skipped.Are there any user-facing changes?
The previous sequential row-group store closes when advancing, and the final store closes with the reader. Callers must finish using a store before advancing.