Repository navigation
fix(symfony): drop translation command probe for object mapper - #8726
Merged
soyuka merged 2 commits intoOct 19, 2026
Merged
Conversation
FrameworkBundle 8.2's TranslationExtractCommand extends a class of the optional symfony/translation package, so probing it with class_exists() is a fatal error when that package is missing. The probe only stood for "framework-bundle >= 7.3", which a composer conflict on <7.4 now guarantees, matching the ^7.4 floor of every other Symfony dependency. Follows up api-platform#8627. Fixes api-platform#8725
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follows up #8627. FrameworkBundle 8.2's
TranslationExtractCommandextends a class of the optionalsymfony/translationpackage, soclass_exists()on it is a fatal error when that package is missing. The probe only stood for "framework-bundle >= 7.3"; a Composer conflict on<7.4now guarantees it (matches the^7.4floor of the other Symfony dependencies) and the object mapper gate keeps onlywillBeAvailable.The new conflict (
symfony/framework-bundle: <7.4, replacing the root6.4.6 || 7.0.6one and added tosrc/Symfony/composer.json) is the only constraint change.Test plan
testObjectMapperGateDoesNotAutoloadTranslationCommandsfails on the previousApiPlatformExtension, passes now.testObjectMapperDoesNotLoadDeprecatedTranslationCommand, which asserted a subset and was skipped without the 8.2 command.Fixes #8725