Repository navigation
Conversation
Constructor arguments bypass setAttributeValue(), so `relationships.<name>.data` reached denormalizeRelation() still wrapped. Unwrap each relationship where attributes and relationships are merged, attributes are left untouched. Fixes api-platform#8702
soyuka
force-pushed
the
fix/jsonapi-constructor-relationship-linkage-8702
branch
from
October 19, 2026 12:14
8fa4fcb to
e619713
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setAttributeValue()strips thedatawrapper ofrelationships.<name>, but constructor arguments never go through it, so to-one linkage failed with "Only resource linkage supported currently" and to-many with a key type error. Thedatakey is now unwrapped on relationships only, where attributes and relationships are merged, an attribute holding adatakey is left intact.Note that the non-spec flat shape (
relationships.author: {"type", "id"}) is still accepted, it already was on the property path and rejecting it would be a BC break on 4.4.