Repository navigation
Conversation
included items referenced the related resource's whole document
definition ({data: {...}}) while the serializer emits bare resource
objects. Move the resource object to its own X.jsonapi.resource
definition, referenced by the document's data and by included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #8734.
included.items.anyOfreferenced the related resource's document definition (X.jsonapi, i.e.{data: {...}}), butincludeditems are bare resource objects ({id, type, attributes, relationships}), so real responses never validated against the documented schema.The resource object now lives in its own
X.jsonapi.resourcedefinition, referenced by the document'sdata(and collectiondata.items) and byincluded, single source of truth. Measured on the fixture app export: 638 new*.resourcecomponents, no removed ones, and every existing component dereferences to exactly its previous shape. Consumers readingX.jsonapi.properties.datainline now get a$ref.Expect a conflict with #8741 (same factory) depending on merge order.