refactor: replace integration test actors with dedicated actors by RobertCrupa · Pull Request #895 · apify/apify-mcp-server

RobertCrupa · 2026-05-21T13:43:50Z

Closes #783.

Integration tests previously depended on apify/python-example, apify/actors-mcp-server, and apify/rag-web-browser. The last one runs a real browser, making those tests slow and expensive.

Replaces them with dedicated test Actors:

apify/normal-mode-test-actor — standard Actor fixture
apify/example-mcp-server — MCP server Actor fixture

src/const.ts RAG_WEB_BROWSER production default is unchanged. Unit tests use Actor names as string fixtures only and were not touched.

Unfortunately, we had to introduce 2 Actor instead of 1 due to issues on the MCP server side, but a separate issue #857 was raised to fix those.

Swap legacy test actors for apify/normal-mode-test-actor and apify/example-mcp-server in the integration suite. Closes #783

Copilot

Pull request overview

This PR updates the integration test suite to stop relying on slow/expensive external Actors by switching test execution to dedicated fixture Actors (apify/normal-mode-test-actor and apify/example-mcp-server), while keeping the production default apify/rag-web-browser unchanged.

Changes:

Replaced most integration test Actor calls/fixtures from python-example / actors-mcp-server / rag-web-browser to the new dedicated test Actors.
Updated integration expectations to match the new test actor’s input/output shape (e.g., firstNumber/secondNumber fields and add tool for the MCP server fixture).
Updated test documentation and constants to reference the new fixture Actors.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
tests/README.md	Updates the documented list of required Actors for running integration tests.
tests/integration/suite.ts	Refactors integration tests to use the new dedicated fixture Actors and updates assertions accordingly.
tests/integration/internals.test.ts	Switches internals integration tests to use the new fixture Actor constant.
tests/const.ts	Replaces old integration fixture Actor constants with the new dedicated fixture Actor constants.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

jirispilka

Thanks Robert! Nice

I left a couple of comments. Some of them were pre-existing but I believe they are worth to fix

Also, pre-existing, we are mixing: ACTOR_NORMAL_MODE_TEST and apify/normal-actor.... worth fixing as well.

jirispilka · 2026-05-21T20:16:53Z

            // Should include actor card header and rating
            expect(ratingText).toContain('Actor information');
-            expect(ratingText).toContain('Rating:');
+            // TODO: re-enable once apify/normal-mode-test-actor has reviews; Rating: is omitted when review count is 0


I also wrote a review, you can re-enable

I would honestly not test the rating as it is something less predictable - for example Robert rated the Actor days ago and the reting is still not there. We can instead write some unit test with Actor info fixture that tests the format function to return the Rating section in the output string.

Unfortunately, the tests still fail...

I will keep them commented out for now.

Co-authored-by: Jiří Spilka <jiri.spilka@apify.com>

MQ37

Went through it and LGTM after you address all the comment from Jirka 👍 Good job!

We also need to deploy this Actor to staging - I will do that

MQ37 · 2026-05-22T08:08:10Z

            // Should include actor card header and rating
            expect(ratingText).toContain('Actor information');
-            expect(ratingText).toContain('Rating:');
+            // TODO: re-enable once apify/normal-mode-test-actor has reviews; Rating: is omitted when review count is 0


I would honestly not test the rating as it is something less predictable - for example Robert rated the Actor days ago and the reting is still not there. We can instead write some unit test with Actor info fixture that tests the format function to return the Rating section in the output string.

MQ37 · 2026-05-22T08:17:27Z

@RobertCrupa @jirispilka two testing Actors deployed to staging

removed all usage of actor name from the tests, we now only rely on the const. Also removed usage of temporary consts that just reference this const

jirispilka

Many thanks for changes!

Thanks 👍🏻

…fixture #895 introduced dedicated test Actors (apify/normal-mode-test-actor, apify/example-mcp-server). The latter is a standby MCP-server Actor by definition, so swap it in for apify/rag-web-browser across all standby/ payment-mode tests that I added in this PR \u2014 keeps integration tests on the dedicated fixtures rather than a production-default Actor. The list-tools filter test is restructured: instead of asserting the default standby Actor (RAG) is dropped from the default Actor list, it now explicitly passes ACTOR_EXAMPLE_MCP_SERVER via the `actors` option and asserts its proxied sub-tools (`*-add`) are filtered under payment mode and present under standard auth.

Closes #783. Integration tests previously depended on `apify/python-example`, `apify/actors-mcp-server`, and `apify/rag-web-browser`. The last one runs a real browser, making those tests slow and expensive. Replaces them with dedicated test Actors: - `apify/normal-mode-test-actor` — standard Actor fixture - `apify/example-mcp-server` — MCP server Actor fixture `src/const.ts` `RAG_WEB_BROWSER` production default is unchanged. Unit tests use Actor names as string fixtures only and were not touched. Unfortunately, we had to introduce 2 Actor instead of 1 due to issues on the MCP server side, but a separate issue #857 was raised to fix those. --------- Co-authored-by: Jiří Spilka <jiri.spilka@apify.com>

refactor: Replace integration test actors

3abf276

Swap legacy test actors for apify/normal-mode-test-actor and apify/example-mcp-server in the integration suite. Closes #783

RobertCrupa force-pushed the refactor/replace-integration-test-actors branch from 1ed03b5 to 3abf276 Compare May 21, 2026 13:55

github-actions Bot assigned RobertCrupa May 21, 2026

github-actions Bot added t-ai Issues owned by the AI team. tested Temporary label used only programatically for some analytics. labels May 21, 2026

RobertCrupa changed the title ~~Replace integration test actors~~ refactor: replace integration test actors with dedicated actors May 21, 2026

docs: Update readme to use pnpm instead of npm

db8327f

RobertCrupa marked this pull request as draft May 21, 2026 14:35

RobertCrupa added 2 commits May 21, 2026 16:39

refactor: undo changes to tests that require 2 actors

5e14984

fix: add removed test back

7a3b339

RobertCrupa requested a review from Copilot May 21, 2026 15:14

Copilot started reviewing on behalf of RobertCrupa May 21, 2026 15:14 View session

RobertCrupa marked this pull request as ready for review May 21, 2026 15:17

RobertCrupa requested review from MQ37 and jirispilka May 21, 2026 15:17

Copilot AI reviewed May 21, 2026

View reviewed changes

Comment thread tests/README.md Outdated

Comment thread tests/integration/suite.ts

Comment thread tests/integration/suite.ts

Comment thread tests/integration/suite.ts

jirispilka requested changes May 21, 2026

View reviewed changes

RobertCrupa and others added 2 commits May 22, 2026 08:39

chore: remove redundant test

7857511

removed redundant tool name check

625a52c

Co-authored-by: Jiří Spilka <jiri.spilka@apify.com>

MQ37 approved these changes May 22, 2026

View reviewed changes

RobertCrupa added 5 commits May 22, 2026 13:08

rename: ACTOR_NORMAL_MODE_TEST -> ACTOR_NORMAL_MODE

47e86d7

docs: remove readme from tests

ad1d313

remane: const actor normal mode no longer named test

53765b1

fix: maxItems for normal actor now correctly tests for 1 item

ddd9b21

refactor: using only const of actor name

e5f0eb2

removed all usage of actor name from the tests, we now only rely on the const. Also removed usage of temporary consts that just reference this const

jirispilka mentioned this pull request May 22, 2026

chore(tests): Split internal integration suite — drop duplicates of public, keep contract smoke #901

Closed

6 tasks

fix: test now verifies tool output text

f037b61

jirispilka self-requested a review May 22, 2026 12:42

jirispilka approved these changes May 22, 2026

View reviewed changes

RobertCrupa merged commit 712fb16 into master May 22, 2026
15 checks passed

RobertCrupa deleted the refactor/replace-integration-test-actors branch May 22, 2026 12:53

Uh oh!

Conversation

RobertCrupa commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jirispilka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jirispilka May 21, 2026

Choose a reason for hiding this comment

Uh oh!

MQ37 May 22, 2026

Choose a reason for hiding this comment

Uh oh!

RobertCrupa May 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MQ37 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MQ37 May 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

MQ37 commented May 22, 2026

Uh oh!

jirispilka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

RobertCrupa commented May 21, 2026 •

edited

Loading