Repository navigation
fix: keep scope case when appending the openid scope - #1102
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
OidcUtils.includeRequiredScopeappendsopenidwhen the requested scope does not contain it. It lowercased every scope to run that check and then built the result from the lowercased list, so a scope such asprofile read:Messagesbecameprofile read:messages openid. Scope values are case-sensitive, so mixed-case API permissions were requested under a different name and not granted.This change runs the case-insensitive
openidcheck without modifying the scopes, and appendsopenidto the scopes as the caller passed them. Requests that already includeopenidare unchanged.No public classes or methods are added, removed or changed. The fix applies to every caller of
includeRequiredScope:ParameterBuilder.setScope,Request.addParameter/addParameterswith ascopevalue, andWebAuthProvider.login(...).withScope(...).References
openidscope #1101Testing
ParameterBuilderTest.shouldKeepScopeCaseWhenAddingRequiredScopesetsprofile read:Messagesand asserts the result isprofile read:Messages openid. The test fails onmain(profile read:messages openid) and passes with this change.This change adds unit test coverage
This change adds integration test coverage
This change has been tested on the latest version of the platform/language or why not
Checklist
I have read the Auth0 general contribution guidelines
I have read the Auth0 Code of Conduct
All existing and new tests complete without errors
Summary by CodeRabbit
openidscope when scopes use varying capitalization.openidwhen needed.