Repository navigation
fix(parameters): cache and transform mixed-batch decrypted parameters - #5841
Merged
dreamorosi merged 1 commit intoOct 25, 2026
Merged
dreamorosi merged 1 commit into
dreamorosi merged 1 commit into
Conversation
dreamorosi
approved these changes
Oct 25, 2026
dreamorosi
enabled auto-merge (squash)
October 25, 2026 08:25
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
getParametersByNamereceived a mix of parameters with and withoutdecrypt: true, the decrypted ones were fetched through the raw_get(), so thetransformwas not applied and the values were never cached. This PR routes them throughget(), so they get the same transform and cache handling as every other parameter.Changes
this.get()instead ofthis._get()inSSMProvider.getParametersByNameWithDecryptOption, and note in its JSDoc that the transform and cache options apply to each parameter.SSMProvider.test.ts: one checks that the transform is applied to the decrypted parameters, the other that they are served from the cache on the next call.get(), an SDK error on this path is wrapped inGetParameterError, as it already is on the other paths.Issue number: closes #5831
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.