Repository navigation
fix(parser): use AWS casing for VPC Lattice v2 identity fields - #5847
Merged
dreamorosi merged 4 commits intoOct 26, 2026
Merged
dreamorosi merged 4 commits into
dreamorosi merged 4 commits into
Conversation
dreamorosi
approved these changes
Oct 26, 2026
dreamorosi
enabled auto-merge (squash)
October 26, 2026 08:34
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The VPC Lattice v2 schema declared four identity fields with keys AWS doesn't send (
principalOrgId,X509SubjectCn,X509IssuerOu,X509SanNameCn). Since the fields are optional and Zod strips unknown keys, the values in real events were silently dropped. This corrects them to the spellings in the AWS documentation, same as the Python fix in aws-powertools/powertools-lambda-python#8628.Changes
packages/parser/src/schemas/vpc-latticev2.ts: rename the keys toprincipalOrgID,x509SubjectCn,x509IssuerOuandx509SanNameCn.x509SanDnsandx509SanUriare unchanged, all identity fields stay optional, and no aliases are kept for the old keys.packages/parser/tests/unit/schema/vpc-latticev2.test.ts: add the tests from the issue (all documented identity fields preserved, an empty identity, and a non-string value rejected for each corrected key). Only formatting changed, frombiome format.VpcLatticeEventV2is still inferred from the schema, so the type picks up the new keys.Unit tests with 100% coverage, type tests and
biome cipass for the parser package. The new tests fail onmain.Issue number: closes #5842
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.