Skip to content

test: cover suspended chained child in OTel - #824

Open
zhongkechen wants to merge 7 commits into
mainfrom
codex/otel-suspended-child
Open

zhongkechen wants to merge 7 commits into
mainfrom
codex/otel-suspended-child

Conversation

@zhongkechen

@zhongkechen zhongkechen commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

The short OTel suite lacked a chained invoke whose child suspends and resumes. Add case 27 handlers in both tracing views: the child performs a one-second durable wait, resumes, and returns the original payload to its caller.

Register both caller/target pairs in the SAM template. Use conformance main for the reusable workflow and both catalog defaults, including the 27-case catalog merged in conformance #131. The Java change can merge independently of Python #796 and JS #1068.

Validation: both local tracing-view tests pass, along with Spotless and the deployable handler bundle build. The tests compile the real handler sources, run caller and child through the public local runner, and verify suspension/resume, stable operation IDs, saved results, and child wait links. The Java local runner completes the caller's invoke with the real child result; service trace propagation is validated separately by cloud CI.

For the workflow reference update, YAML parsing and reusable-workflow input/secret compatibility checks passed against conformance main. Case 27 is present in both tracing-view catalogs.

@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 26, 2026 18:53 — with GitHub Actions Active
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 26, 2026 19:53 — with GitHub Actions Active
@github-actions

This comment has been minimized.

Keep the updated shared OTel orchestrator while retaining the 27-case catalog and suspended-child coverage.
@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 26, 2026 20:33 — with GitHub Actions Active
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 26, 2026 20:43 — with GitHub Actions Active
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 26, 2026 21:19 — with GitHub Actions Active
@github-actions

Copy link
Copy Markdown
Contributor

Codex AI review

No actionable findings. Residual test risk: tests were not executed under the read-only restriction; cloud trace propagation and external workflow/catalog compatibility were not independently verified.

Reviewed commit e91adf0d384a993bc327745f120113bfeb9245a8. Workflow run

This branch was successfully deployed

1 active deployment
ai-pr-review-runtime — e91adf0d Deployed Oct 26, 2026 by zhongkechen via ai-pr-review / Codex review / Generate Codex review #2729
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant