Repository navigation
Conversation
Preserve legacy unitless GiB inputs while normalizing explicit Kubernetes units. Keep exponent-form quantities intact through allocation and reject invalid values before mutation. Signed-off-by: shin0343 <shin0343@mail.hongik.ac.kr>
shin0343
requested a deployment
to
manual-approval
October 25, 2026 16:07 — with
GitHub Actions
Waiting
Author
|
The current head is Could a maintainer approve CI for this head? Local validation recorded in the PR includes 1,286 passing unit tests on Python 3.11 and 39 quantity regression cases. No live AWS/EKS validation was performed. |
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changing and why?
Handle explicit CPU and memory units during training quota allocation. Previously, CPU
500mraised a conversion error and memory1024Miwas interpreted as 1024 GiB before clipping. Parse explicit Kubernetes units, preserve exponent notation through quota calculations, and emit fixed-point GiB quantities.Retain unitless memory's existing GiB meaning, including values emitted by already-installed
hyperpod-pytorch-job-templateversions. Reject negative/non-finite/overflowing quantities before mutating the job.Before/After UX
Before: A request of
cpu=500m, memory=1024Mifailed or allocated the wrong memory amount. Small memory-only requests could also corrupt the derived CPU value.After: The request resolves to 0.5 CPU and 1 GiB. Ki/small-memory quantities preserve their value, and existing CLI/template GiB inputs retain their allocations.
How was this change tested?
git-secretsandgit diff --check.PYTHONPATH=src python -m pytest --confcutdir=test/unit_tests -o addopts='' -q test/unit_testsusing the prepared environment. The flag avoids the parent template-install hook; default coverage options are separated.Are unit tests added?
Yes, 39 parameterized/public-allocation cases.
Are integration tests added?
No live AWS/EKS tests. Existing and new tests run locally without provisioning infrastructure.
Reviewer Guidelines