Skip to content

fix(serve): pin pandas below 3.1.0 to unblock serve unit tests #6524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mufaddal-rohawala merged 2 commits into from
Oct 23, 2026
Merged

fix(serve): pin pandas below 3.1.0 to unblock serve unit tests #6524

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4288634
fix(serve): pin pandas to 2.x in test extra to unblock unit tests
Oct 22, 2026
372ddb3
fix(serve): cap pandas below 3.1.0 (last-known-good 3.0.6)
Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions sagemaker-serve/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,13 @@ test = [
"onnxruntime",
"torch>=2.0.0",
"tritonclient[http]",
# pandas is pulled in transitively (e.g. via mlflow). Cap below 3.1.0:
# pandas 3.1.0 ships wheels built against a newer NumPy C-ABI than the
# py311/py312 test envs resolve, so it fails to import ("ImportError:
# C extension: None not built") at pytest collection time. The previous
# release 3.0.6 was passing on py311/py312; py310 stays on the 2.x line

@github-actions github-actions Bot Oct 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Low: Minor: the PR description states the constraint is pandas>=2.3.0,<3 (a hard cap below 3.x), but the actual pin here is pandas>=2.3.0,<3.1.0, which still permits pandas 3.0.x on py311/py312. The inline comment's reasoning is internally consistent (it says 3.0.6 passed and only 3.1.0 broke), so the <3.1.0 cap is intentional — just worth updating the PR description so reviewers aren't confused about which cap was actually applied. Note that team precedent (Source: #4983) discourages hard single-major caps; <3.1.0 is a narrower upper bound and acceptable, but consider whether <3.1.0 vs a future relaxation is tracked anywhere so the temporary cap doesn't linger.

# (2.3.3) because pandas 3.x requires Python >=3.11.
"pandas>=2.3.0,<3.1.0",
]
dev = [
"pytest",
Expand Down
Loading