Repository navigation
fix(BBBSpinner): clip the rotating svg to its box - #104
Merged
Merged
Conversation
The spinner rotates its whole svg, and the corners of that square sweep past the wrapper as it turns: a 16px spinner reaches about 22.6px across its diagonal. Browsers count the transformed box as scrollable overflow, so a spinner at the edge of a scroll container makes that container show a scrollbar, as in the last row of a BBBToast, whose body scrolls past `maxHeight`. Clip the wrapper to its box. The drawn circle (radius 20 in a 50x50 viewBox, plus half the stroke) stays inside the box at any angle, so only the empty corners of the svg are clipped; a stroke wider than 10 would start to be cut.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The spinner rotates its whole svg, and the corners of that square sweep past the wrapper as it turns: a 16px spinner reaches about 22.6px across its diagonal. Browsers count the transformed box as scrollable overflow, so a spinner at the edge of a scroll container makes that container show a scrollbar, as in the last row of a BBBToast, whose body scrolls past
maxHeight.Clip the wrapper to its box. The drawn circle (radius 20 in a 50x50 viewBox, plus half the stroke) stays inside the box at any angle, so only the empty corners of the svg are clipped; a stroke wider than 10 would start to be cut.