Repository navigation
Conversation
bnbong
added
documentation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fbdf83be2e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| api_router.include_router(items_router.router) | ||
| api_router.include_router(users_router.router) # ← add | ||
| ``` | ||
| Die items-spezifische Reset-Fixture setzt die neue Domäne nicht zurück. Überschreiben Sie deren Service-Dependency für jeden Test mit einem frischen Repository: |
There was a problem hiding this comment.
For projects generated from the v1.5 domain-starter template, this statement is false: tests/conftest.py-tpl discovers every domain package and calls its service.reset_store() before and after each test. The paragraph therefore contradicts the same page's later description and unnecessarily tells users to add dependency overrides. The equivalent newly added paragraph in the other five translated tutorials has the same error.
Useful? React with 👍 / 👎.
1 participant
Requesting Merging
Description
Fix
virtualenvdeps alert, update docsType of Change
Test Environment
Local, M1 MacOS
Major Changes
virtualenvat dev deps in pyproject.tomldomain-starter,adding-routes,cli-referencesto all languagesScreenshots (optional)
N/A
Etc
N/A