Repository navigation
fix(capability): a product clash is a question for the user, not an error - #514
Closed
sarve-shreyas wants to merge 1 commit into
Closed
sarve-shreyas wants to merge 1 commit into
sarve-shreyas wants to merge 1 commit into
Conversation
…rror searchCapability refused an ambiguous request through the same path as a real refusal, so every client rendered the clash in red and agents narrated "the search failed" before asking. The search still does not run, but the outcome now comes back as an ordinary result — status "ask_user", the message, the routing token and the clarify block — and the products in the question, its options and the mismatch text are named by title. Telemetry counts it under ask_user_reason rather than refusal_reason; the tests that detected the gate through isError detect it through status. Stacked on infra-capability. Reapplies 04e267f, bb1a578, a349c75 and 39a71d6, which that branch reverted in c3f6965. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Collaborator
Author
|
Closing for now; the clash-as-question change can be re-raised against main if wanted (branch fix/search-clash-ask-user keeps the commit). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on
infra-capability(PR #491); merge after it.searchCapabilityrefused an ambiguous request through the samerefuse()path as a real failure, so clients rendered the product clash in red and agents narrated "the search failed" before asking the user. The clash is the expected outcome of an ambiguous request, not a fault.The search still does not run — the gate is unchanged — but the outcome comes back as an ordinary result:
{ "status": "ask_user", "reason": "product_ambiguous", "message": "…", "routing_token": "…", "clarify": { "question": "Which product do you mean — …?", "shared": [...], "options": [...] } }isError, noerrorkeytitle(from feat(capability-registry): onboard the infra products, and the mechanisms they needed #491) rather than keyask_user_reasoninstead ofrefusal_reasonisErrornow detect it throughstatusMeasured on a live session:
searchCapabilityon tm with "list all projects" and nouser_words→ "came back as a normal result, not a tool error… status: ask_user… Which product do you mean — Load Testing or Test Management or Test Reporting & Analytics?", and the agent stopped there.Not changed here, same shape if wanted later:
invokeCapability'spermission_not_grantedis also an expected pause returned as an error.🤖 Generated with Claude Code