Repository navigation
Conversation
…heir run's build id, Workflow Analyzer links A user usually has only a report's dashboard link, and two kinds of link failed: - A Website Scanner link carries the run's build id (thBuildId), not the scan's ids, so the tool searched the 15 newest pages of the scan list for it. A scan run more than a few hundred scans ago (page 36 of a 3,000-scan account) was "not found", and agents fell back to Ask AI or asked the user for ids the dashboard does not show. The link is now read by its build id through the scanner issues route that takes one (browserstack/accessibility#5689), however old the scan; later pages and a still-generating export are named by the same link. If the API does not know the run by that id (an API without the route answers a 404 page; one that does, a 404), the scan list is searched as before, and the answer says which happened. Comparing runs needs the scan's ids, so compareWith from a link still searches the list. - A Workflow Analyzer link (workflow-analyzer/report?ids=…, or the older reports/report) was not recognised. It is now read by the report id it carries; a link opening several reports asks for one, and an Assisted Test link says this tool does not read those. A build id that neither the Automated Tests nor the App Accessibility API knows is tried as a Website Scanner run's build id before it is refused. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A user usually has only a report's dashboard link. Two kinds of link failed:
thBuildId), not the scan's ids. The tool therefore searched the newest 15 pages of the scan list (375 scans) for a scan whose link matched.buildId(rejected), then Ask AI (step limit), then asked the user for ids the dashboard doesn't show./workflow-analyzer/report?ids=…) were not recognised at all.What
Scanner links are read by the run's build id
scanBuild, with no API call.GET /api/website-scanner/v1/scan_runs/issues?thBuildId=…, from browserstack/accessibility#5689). It uses the same CSV export and polling as the other sources, so the link works however old the scan is.reportUrl: "…/site-scanner/projects/<name>/builds?thBuildId=…"). Later pages need no scan ids.compareWithfrom a scanner link still needs the scan's ids, so it still searches the list.Workflow Analyzer links are read by the report id they carry
/workflow-analyzer/report?ids=Nand the older/reports/report?ids=Nwork.workflowReportId.Assisted Test links (
/assisted-test/report?ids=…) now say plainly that this tool doesn't read Assisted Test reports, instead of the generic "this link does not name a report".A
buildIdno build API knows (when the Automated Tests and App Accessibility APIs both answer 404) is tried as a Website Scanner run's build id before it is refused. The refusal then names all three APIs, or, where the API has no route yet, points at the report link.The "where ids come from" line in the tool description is left to #524, which changes it (it drops the Ask AI pointer) and would otherwise conflict.
docs/TOOLS.mdis updated.Verified
npm run build: lint, prettier, 1,616 tests, tsc. New tests inaccessibilityReportLinks.test.ts, plus flow tests inaccessibilityScanOutput.test.tsandaccessibilityFetchPagesAndCompare.test.ts. They cover the route and its URLs, both kinds of 404, the fallback, both Workflow Analyzer link forms, several ids, the Assisted Test message, thebuildIdfallthrough, and comparing from a link.?ids=)🤖 Generated with Claude Code