Repository navigation
docs(wire-format): a CK v3 frame header may end in spaces that align the payload (LAB-9999) - #193
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 42 minutes. View limit details
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
Summary by CodeRabbit
WalkthroughThe wire-format specification and changelog describe optional ASCII-space padding in CK v3 headers. The reference generator and test vector add a frame with padding included in ChangesCK v3 header padding
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Merge Risk: ⚪ Minimal · up to
|
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Providing Context (Files & MCPs)Add these hints in your PR description (or a comment) to unlock deeper checks:
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
3d64631
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Providing Context (Files & MCPs)Add these hints in your PR description (or a comment) to unlock deeper checks:
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
b79285d
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Providing Context (Files & MCPs)Add these hints in your PR description (or a comment) to unlock deeper checks:
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
A CK v3 frame's HEADER may now be followed by ASCII spaces, counted in
HDR_LEN, that align the payload. cachekit-py uses this for uncompressed, unencrypted Arrow payloads, so the Arrow IPC file starts on a 64-byte boundary of a File backend cache file (polars copies misaligned numeric columns): cachekit-io/cachekit-py#581.spec/wire-format.md, "Python: CK v3 frame", HEADER bullet: one MAY clause, no new MUST, so no requirement id.changelog.d/20261018_lab-9999.md: the entry.test-vectors/python-frame.json: a newpadded_header_framevector (raw_payload_framewith its header padded so the payload starts at frame offset 128), generated bytools/python-frame-reference.py. Both reference readers parse it to the same header and payload, so a reader that rejected padding would now fail conformance. It is parse-level only: an SDK test that re-wraps vectors byte for byte must skip it.conformance/coverage.mdis regenerated; it now marks the SDKs' vendoredpython-frame.jsoncopies as behind the current revision.Not breaking. JSON allows trailing whitespace, so a reader parses a padded header unchanged; both reference readers use their language's standard JSON parser. Unpadded frames stay valid, and every existing vector is unchanged.
tools/conformance.py check,tools/python-frame-reference.py verify,tools/test_python_frame_reference.py,tools/frame-crosscheck.mjsandtools/test_changelog_collect.pypass.Closes LAB-9999