Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/verify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:

- uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5
with:
python-version: "3.12"
python-version: "3.15"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kody code-review Bug medium

Version mismatch in verify.yml setup-python steps: both jobs set python-version: "3.15", while the PR title and update table target 3.14 and list 3.15.0 as Pending. When no stable 3.15 build exists, both jobs fail at setup because neither step sets allow-prereleases: true. When 3.15 does resolve, the native packages pinned on line 46 (cryptography==49.0.0, lz4==4.4.5, xxhash==4.0.1, msgpack==1.2.1) have no confirmed 3.15 wheels, so pip either fails building from source or the step stops testing the C implementation its label claims. Fix: set python-version: "3.14" in both setup-python steps.

- uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5
  with:
    python-version: "3.14"
Prompt for LLM

File .github/workflows/verify.yml:

Line 22:

Version mismatch in verify.yml setup-python steps: both jobs set `python-version: "3.15"`, while the PR title and update table target 3.14 and list 3.15.0 as Pending. When no stable 3.15 build exists, both jobs fail at setup because neither step sets `allow-prereleases: true`. When 3.15 does resolve, the native packages pinned on line 46 (cryptography==49.0.0, lz4==4.4.5, xxhash==4.0.1, msgpack==1.2.1) have no confirmed 3.15 wheels, so pip either fails building from source or the step stops testing the C implementation its label claims. Fix: set `python-version: "3.14"` in both setup-python steps.

Suggested Code:

      - uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5
        with:
          python-version: "3.14"

Talk to Kody by mentioning @kody

Was this suggestion helpful? React with πŸ‘ or πŸ‘Ž to help Kody learn from this interaction.

​

​


- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
with:
Expand Down Expand Up @@ -127,7 +127,7 @@ jobs:

- uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5
with:
python-version: "3.12"
python-version: "3.15"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kody code-review Bug medium

Version mismatch in the conformance job's setup-python step: it sets python-version: "3.15" instead of the 3.14 the PR targets. When no stable 3.15 build is available to setup-python, this job fails at setup, just like the test-vectors job, because allow-prereleases: true is not set. Fix: set python-version: "3.14".

python-version: "3.14"
Prompt for LLM

File .github/workflows/verify.yml:

Line 130:

Version mismatch in the conformance job's setup-python step: it sets `python-version: "3.15"` instead of the 3.14 the PR targets. When no stable 3.15 build is available to setup-python, this job fails at setup, just like the test-vectors job, because `allow-prereleases: true` is not set. Fix: set `python-version: "3.14"`.

Suggested Code:

          python-version: "3.14"

Talk to Kody by mentioning @kody

Was this suggestion helpful? React with πŸ‘ or πŸ‘Ž to help Kody learn from this interaction.

​

​


- name: Conformance index (stdlib only; mutation suite first)
env:
Expand Down
Loading