Repository navigation
Conversation
markstory
approved these changes
Oct 21, 2026
| { | ||
| $config = $this->_config; | ||
| if (isset($config['salt']) && is_string($config['salt'])) { | ||
| $config['salt'] = '*****'; |
Member
There was a problem hiding this comment.
I think scrubbing these is a great idea. Should we preserve the last 3 or 4 bytes though so that developers can validate that secrets/keys are correct?
Member
Author
There was a problem hiding this comment.
I added a new trait method for redaction. AI suggested to show the last 4 bytes only if the string is longer than 8 chars :) Let me know if you want to adjust/remove that.
Allows developers to verify that the correct secret/key is configured without exposing the full value. Secrets of 8 bytes or less are masked entirely. The shared masking rule lives in RedactionTrait. Also only redact string values in AuthenticationService's nested config, so boolean flags like CookieAuthenticator's salt stay visible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.