fix(ci): preserve manual Android suite timing

[thymikee]

Summary

The pinned emulator action starts a separate shell for each script line, losing Android setup/full-suite timestamps and reporting negative setup and zero suite durations.

Run the existing pipeline through one shell using the action's emulator serial. Record both timings even if full E2E fails, then preserve its exit code and stop before ordinary replay. Four files changed; prerequisite for #3555 and #3077 validation.

Validation

Tested head: f660374efbf42d270e9edcabaa8e3bd8f866510e, rebased onto main 15cfe9fa2 including merged test repairs #3590. Both layer commits are unchanged by range-diff.

Regression	Before	After
Lost timestamp state	8255c735: FAIL (-90s/0s)	PASS (10s/25s)
Failed full suite loses timing	f9260b1ee: 1 FAIL / 2 PASS	3 PASS; exit 13, no replay

Three focused cases cover two independent serials; hardcoding the first serial fails both other-serial cases. Mutation restored. Frozen install/build and exact-head pnpm check:affected --base 15cfe9fa2 --run pass all runnable gates, including 1,760 Vitest files / 14,891 passed tests / one skip. Fresh combined-stack review has no findings. Integration passed. iOS smoke failed during runner startup after preflight passed; one failed-job rerun was requested based on retained Xcode worker/listener evidence. Startup-stall cause remains unknown; no budgets or assertions changed. Coverage and remaining checks are pending.

Earlier hosted Android, runtime a3aba45a, reports setup 92s/full 398s. Pure workflow repair; no new device behavior.

[cubic-dev-ai]

All reported issues were addressed across 4 files

<sub>Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic</sub>

[github-actions]

Size Report

Metric	Base	Current	Diff
Installed (including dependencies)	5.20 MB	5.20 MB	0 B
Package (unpacked)	5.20 MB	5.20 MB	0 B
Package (download)	1.56 MB	1.56 MB	-2 B

Startup median (7 runs, lower is better):

Scenario	Base	Current	Diff
CLI --version	17.3 ms	17.2 ms	-0.2 ms
CLI --help	50.0 ms	48.9 ms	-1.1 ms

[thymikee]

I reviewed 22fb210 and found no problems in the code. The manual Android replay job now keeps the suite timing, and the script keeps the real exit status after it prints both timings. The test uses distinct serials, so a hardcoded serial would fail. All 22 checks pass, and there are no conflicts. Nothing else blocks merge. The earlier hosted manual Android run reproduced the timings, but I did not run the vitest case or the failure path on the hosted emulator, so exit-code preservation rests on the stubbed test and reading the code.

Both inline threads from cubic-dev-ai are fixed at this commit, so you can resolve them: #3554 (comment) (the test now uses emulator-7000 and emulator-8100, and the adb stub rejects a mismatch) and #3554 (comment) (the script saves the status with || FULL_STATUS=$?, prints both timings, then exits with it).

Two small, optional notes. The stubbed adb devices branch in android-manual.test.ts is never reached now, because the script no longer calls it. A short comment in the script saying the action exports ANDROID_SERIAL would help the next reader. android.yml still guesses the serial, which could be a separate change.

[thymikee]

Thanks for the update. The Android serial and exit-code handling from the earlier pass (22fb210) are now fixed at a85a0f0, and I found nothing new in the code. The two inline threads on the distinct emulator serials and on keeping the full-suite exit status both look fixed at this head, so you can resolve them: #3554 (comment) and #3554 (comment).

I judged the stubbed test from the diff and the script. I did not run the vitest case or the hosted emulator path. I also did not open hosted run 38324090019, so I have not confirmed that the emulator action exports ANDROID_SERIAL to the script. The exit-code behavior on a real emulator rests on the stubbed test and on reading the code. I did not review the 122-file rebase delta, since it is upstream content.

No conflicts. The two Smoke Tests runs and Mutants (snapshot-occlusion) are still pending, not failed. This patch only touches the manual workflow, the Android manual script and its test, and a vitest exclusion, so those jobs can only be affected by the rebased-in base changes. Merge once those jobs finish green.

[github-actions]

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-10-14 08:00 UTC