Repository navigation
test(test-app): add a perf lab with seeded React render problems - #3612
Conversation
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
|
The PR is ready at e98bb92. I found no blocking problems in the diff. Not blocking, and you can take or leave these: in EagerListScenario the step is The cubic-dev-ai P2 thread on the double-slash deep link does not apply: expo-router should treat a bare The failed Smoke Tests job looks unrelated. It died in the Install Android SDK step, where sdkmanager reported "Error on ZipFile unknown archive" for the android-36 system image and the emulator never started. The diff only touches examples/test-app JS and the README, and no daemon or Android runtime code. A second Smoke Tests run is still in progress, so the Android job needs a re-run before merge. I did not run a device or re-run |
e98bb92 to
c51097f
Compare
|
At
|
|
The perf lab change at c51097f looks good. The logical delta since the earlier review at e98bb92 touches two files, and I found no problems in it. The deep-link form in the README is unchanged, and the author says live Android runs opened The one open inline thread on the deep-link form does not apply any more, so please resolve it: #3612 (comment). The README uses a different route shape for I ran nothing locally. I checked the render and mount behavior, the deep-link resolution and the profiler findings from the code and from the author's live-run claims only. The expected finding names in the README, such as CI is still pending. 14 of 18 jobs are queued and none has failed. This PR touches only |
|
Summary
Adds a Perf lab screen to the test-app: seven seeded JavaScript render problems for the built-in React profiler in #3613 / #3618. Each scenario renders one culprit and a Run button that replays the slow interaction as a fixed burst, then sets
perf-statustodone. Open one withagent-device-test-app://perf-lab?scenario=<id>.expensive-rendermemo-defeatedcontext-cascadeparent-cascaderender-stormeffect-chaineager-listPerfLabScreen.tsximports only React and React Native, so it can be copied into bare apps to check other RN versions. The README lists the finding each scenario should produce. Touches 4 files underexamples/test-app(380 lines).Validation
At
c51097fd1d,pnpm check:affected --runpasses and the test-apptsc --noEmitpasses.Live runs on RN 0.88-rc Android used deep links of the
agent-device-test-app://perf-lab?scenario=<id>form, opened both withagent-device openandadb am start. The same file, copied into bare RN 0.74, 0.76, 0.80 and 0.83 apps, produced each scenario's expected first finding on Android and on the RN 0.83 iOS simulator (results in #3613).