Skip to content

chore(interaction): remove retired readiness forwarding - #3637

Merged
thymikee merged 1 commit into
mainfrom
chore/remove-retired-readiness-forwarding
Oct 15, 2026
Merged

thymikee merged 1 commit into
mainfrom
chore/remove-retired-readiness-forwarding

Conversation

@thymikee

@thymikee thymikee commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

Summary

Remove interaction readiness forwarding left after the target wait's producer and public contract were retired. Preserve prior warnings and typed replay-cause evidence.

Five files: delete the two forwarding sites and obsolete response/replay/MCP fixtures. Runner and device readiness are unchanged.

Closes #3607.

Validation

Tested head: 3d8da459f140124215ffcc05184d30040137630b (base fc224bc1e1).

  • pnpm check:affected --base fc224bc1e1 --head 3d8da459f1 --run: passed.
  • Fresh-context review: no actionable findings.
  • Deletion-only cleanup; no regression is attributed to a live producer.

CI checks are pending. No live-device verification was needed for removing unreachable forwarding.

View guided diff Turn on auto-fix

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

View guided diff | Turn on auto-fix | Re-trigger cubic

@github-actions

Copy link
Copy Markdown
Contributor

Size Report

Metric Base Current Diff
Installed (including dependencies) 5.25 MB 5.25 MB -68 B
Package (unpacked) 5.25 MB 5.25 MB -68 B
Package (download) 1.58 MB 1.58 MB -24 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 26.6 ms 26.1 ms -0.5 ms
CLI --help 77.6 ms 76.0 ms -1.6 ms

@thymikee

Copy link
Copy Markdown
Member Author

The code in 3d8da45 looks good. Removing the retired readiness forwarding is a deletion-only change, and I found nothing wrong with it. I did not run pnpm check:affected or any tests locally, so this is a read of the diff. The Coverage job failed, but its step log is not available yet, so I can't rule out a threshold or flake cause. Because the diff adds no routes, exports or API surface, I think the failure is unrelated. Please check the log once it exists. Compatibility & Provenance is still queued. There are no conflicts. No code change is needed. Before merge, Coverage must go green and Compatibility & Provenance must finish.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Oct 15, 2026
@thymikee
thymikee merged commit 8015735 into main Oct 15, 2026
18 of 19 checks passed
@thymikee
thymikee deleted the chore/remove-retired-readiness-forwarding branch October 15, 2026 12:20
@thymikee

Copy link
Copy Markdown
Member Author

Inspected the completed Coverage log. Its sole failing test was the stale packages/daemon/src/index.ts over-ceiling approval, not readiness behavior or a coverage threshold. Main removed that expired row in #3653. Compatibility & Provenance also finished successfully. This PR is already merged, so no further readiness change is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove interaction readiness result forwarding left after the readiness-wait removal

1 participant