You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Remove interaction readiness forwarding left after the target wait's producer and public contract were retired. Preserve prior warnings and typed replay-cause evidence.
Five files: delete the two forwarding sites and obsolete response/replay/MCP fixtures. Runner and device readiness are unchanged.
The code in 3d8da45 looks good. Removing the retired readiness forwarding is a deletion-only change, and I found nothing wrong with it. I did not run pnpm check:affected or any tests locally, so this is a read of the diff. The Coverage job failed, but its step log is not available yet, so I can't rule out a threshold or flake cause. Because the diff adds no routes, exports or API surface, I think the failure is unrelated. Please check the log once it exists. Compatibility & Provenance is still queued. There are no conflicts. No code change is needed. Before merge, Coverage must go green and Compatibility & Provenance must finish.
Inspected the completed Coverage log. Its sole failing test was the stale packages/daemon/src/index.ts over-ceiling approval, not readiness behavior or a coverage threshold. Main removed that expired row in #3653. Compatibility & Provenance also finished successfully. This PR is already merged, so no further readiness change is needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ready-for-humanValid work that needs human implementation, judgment, or maintainer merge
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove interaction readiness forwarding left after the target wait's producer and public contract were retired. Preserve prior warnings and typed replay-cause evidence.
Five files: delete the two forwarding sites and obsolete response/replay/MCP fixtures. Runner and device readiness are unchanged.
Closes #3607.
Validation
Tested head:
3d8da459f140124215ffcc05184d30040137630b(basefc224bc1e1).pnpm check:affected --base fc224bc1e1 --head 3d8da459f1 --run: passed.CI checks are pending. No live-device verification was needed for removing unreachable forwarding.