Repository navigation
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
|
I found no code problems at f3312d0. The new root export, the docs line and the two tests look right. CI has not run for this head. All 13 remaining checks are queued, so nothing has failed yet. I did not run the new test locally, and I did not see the installed-package export check or the typecheck and package build run. No conflicts. Not blocking: the line at https://github.com/callstack/agent-device/blob/f3312d0/website/docs/docs/client-api.md#L36 could say the predicate only recognizes the Android helper content reasons (empty-helper-output, system-window-only, content-poor-app-window) from the local ADB helper capture, and returns false for every other backend and platform; the new test in src/sdk/index.test.ts overlaps the contract-level predicate tests, but it is fine to keep for the root-entry round trip. You can take or leave both. The open docs-scope thread (#3664 (comment)) still applies and is the same wording point. Before merge, wait for the queued checks, especially Integration Tests (the installed-package export list) and Typecheck & Package. |
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
The code in c6e028f looks good to me. Since the review at f3312d0, the docs now scope I found no code problems. I did not run CI has not finished: 13 checks are still queued and none have failed. The diff changes the root export list that the Integration Tests installed-package test checks, and the type surface that Typecheck & Package builds, so neither can be judged yet. Please wait for those checks to finish, especially those two, before merging. |
empty-helper-output,content-poor-app-window,system-window-only) while the app is loading. agent-device already retries internally and throws a retriableCOMMAND_FAILED.isUnreadableCaptureContentErrorfrom the root entry, with docs and a test.toBeVisibleon Android in react-navigation CI, consumer fix in tester-army/e2e.