Skip to content

feat(sdk): export isUnreadableCaptureContentError - #3664

Merged
thymikee merged 2 commits into
callstack:mainfrom
okwasniewski:oskar/retry-unusable-android-snapshots
Oct 15, 2026
Merged

thymikee merged 2 commits into
callstack:mainfrom
okwasniewski:oskar/retry-unusable-android-snapshots

Conversation

@okwasniewski

@okwasniewski okwasniewski commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor
  • Android snapshots can come back unreadable (empty-helper-output, content-poor-app-window, system-window-only) while the app is loading. agent-device already retries internally and throws a retriable COMMAND_FAILED.
  • Callers that poll (e.g. locator assertions in test runners) need to tell this apart from real failures. This exports isUnreadableCaptureContentError from the root entry, with docs and a test.
  • Context: flaky toBeVisible on Android in react-navigation CI, consumer fix in tester-army/e2e.

View guided diff

Copilot AI balanced review requested due to automatic review settings October 15, 2026 12:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files

Reply with feedback, questions, or to request a fix.

View guided diff | Re-trigger cubic

Comment thread website/docs/docs/client-api.md Outdated
@thymikee

Copy link
Copy Markdown
Member

I found no code problems at f3312d0. The new root export, the docs line and the two tests look right. CI has not run for this head. All 13 remaining checks are queued, so nothing has failed yet. I did not run the new test locally, and I did not see the installed-package export check or the typecheck and package build run. No conflicts. Not blocking: the line at https://github.com/callstack/agent-device/blob/f3312d0/website/docs/docs/client-api.md#L36 could say the predicate only recognizes the Android helper content reasons (empty-helper-output, system-window-only, content-poor-app-window) from the local ADB helper capture, and returns false for every other backend and platform; the new test in src/sdk/index.test.ts overlaps the contract-level predicate tests, but it is fine to keep for the root-entry round trip. You can take or leave both. The open docs-scope thread (#3664 (comment)) still applies and is the same wording point. Before merge, wait for the queued checks, especially Integration Tests (the installed-package export list) and Typecheck & Package.

Copilot AI balanced review requested due to automatic review settings October 15, 2026 14:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@thymikee

Copy link
Copy Markdown
Member

The code in c6e028f looks good to me. Since the review at f3312d0, the docs now scope isUnreadableCaptureContentError to the three Android helper reasons and say it is false for other platforms and backends, so the earlier docs thread (#3664 (comment)) is fixed and you can resolve it.

I found no code problems. I did not run src/sdk/index.test.ts or the installed-package integration test. I also did not confirm that tsdown bundles @agent-device/contracts into the published root entry. The export list in installed-package-metro.test.ts guards that.

CI has not finished: 13 checks are still queued and none have failed. The diff changes the root export list that the Integration Tests installed-package test checks, and the type surface that Typecheck & Package builds, so neither can be judged yet. Please wait for those checks to finish, especially those two, before merging.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Oct 15, 2026
@thymikee
thymikee merged commit 6279da7 into callstack:main Oct 15, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants