Repository navigation
refactor(move): move the interaction-guarantee and command-doc guards to test/repo-guards - #3680
Merged
Merged
Conversation
… to test/repo-guards (pure git mv) Path fixes follow in the next commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…epo-guards Root-relative paths, the check:command-docs script path, and path samples in gate tests and a workflow comment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
|
Contributor
Size Report
Startup median (7 runs, lower is better):
|
Member
Author
|
This PR is ready at fa2f289. The moved guards and the updated command-docs-gate path and unit-core include look correct. Not blocking: the comments in test/integration/interaction-contract/index.ts and coverage-manifest.ts name src/tests/contracts/interaction-contract-coverage.test.ts, which this PR does not touch, so you can take or leave that. I did not run the moved tests or pnpm check:command-docs locally. This is from reading the diff, the vitest config and git grep. The checks (Repo Guards, command-docs-gate, Typecheck & Package) are queued with none failed, and I see no overlap between the changed paths and a likely failure. No conflicts. Once those checks pass, it can merge. |
thymikee
added
the
ready-for-human
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Class i, two more artifact guards move from
src/__tests__totest/repo-guards/(already selected by thetest/repo-guards/*.test.tsentry from #3663), keeping their names:contracts/interaction-guarantees(+ its helperrunner-source-assertions.ts): the ADR 0011 matrix gate asserts that everyviasymbol exists in the referenced module or Swift runner source and every waiver carries a reason. It reads repo files, not one contracts module.command-doc-coverage: pinsPUBLIC_COMMANDSagainstwebsite/docs/docs/commands.mdin both directions. It is thecheck:command-docsgate, so its callers move with it.Commit 1 is a pure
git mv(0 content lines). Commit 2 fixes the repo-root path in the helper, the two schema imports, thecheck:command-docsscript path inpackage.json, path samples inscripts/gate/model.test.tsandscripts/check-affected/device-lanes.test.ts, and thepr-preview.ymlcomment that names the file. No new vitest project,exports, barrel or fixture change.Validation
Head
fa2f28987:check:quick,check:layering,check:fallow,check:gate-manifest,check:affected --run(full set, becausepackage.jsonand a workflow changed) andpnpm formatpass.unit-core;pnpm check:command-docsstill runs the moved file (12 passed); thecheck:affected:testsuite (66) andscripts/gate/model.test.ts(7) pass with the edited samples.interaction-guaranteesfail 2 of 9 (runner source not found); restored.vi.mock: none.🤖 Generated with Claude Code