Skip to content

chore(daemon): declare @agent-device/proxy as a devDependency - #3685

Merged
thymikee merged 1 commit into
mainfrom
refactor/daemon-proxy-devdep
Oct 15, 2026
Merged

thymikee merged 1 commit into
mainfrom
refactor/daemon-proxy-devdep

Conversation

@thymikee

@thymikee thymikee commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

Summary

Follow-up promised in #3638: @agent-device/proxy moves from dependencies to devDependencies in packages/daemon/package.json, because only http-server-proxy.test.ts imports it. R11 accepts devDependencies for test-file imports since #3659. The lockfile moves the same entry from the dependencies to the devDependencies block of the daemon importer; no package version changes.

Evidence

🤖 Generated with Claude Code

View guided diff Turn on auto-fix

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

View guided diff | Turn on auto-fix | Re-trigger cubic

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Size Report

Metric Base Current Diff
Installed (including dependencies) 5.24 MB 5.24 MB 0 B
Package (unpacked) 5.24 MB 5.24 MB 0 B
Package (download) 1.57 MB 1.57 MB -6 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 27.9 ms 26.9 ms -1.0 ms
CLI --help 78.0 ms 81.1 ms +3.1 ms

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://callstack.github.io/agent-device/pr-preview/pr-3685/

Built to branch gh-pages at 2026-10-15 18:14 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

…only a test imports it

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@thymikee
thymikee force-pushed the refactor/daemon-proxy-devdep branch from 698b115 to e04dc79 Compare October 15, 2026 17:47
@thymikee

Copy link
Copy Markdown
Member Author

Moving @agent-device/proxy to a devDependency of the daemon package looks correct at e04dc79. The diff touches only package.json and the lockfile, and production code does not import the proxy package, so I see no runtime change.

I did not run pnpm install --frozen-lockfile or the layering gate. I also did not check whether the proxy package depends on the daemon, which would be a cycle. I did not check how this affects published consumers of the daemon package either, though that impact looks unlikely.

The Smoke Tests are queued and have not failed. This change cannot alter any route they exercise. There are no conflicts. Once the queued checks finish green, this is ready to merge.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Oct 15, 2026
@thymikee
thymikee merged commit fbf9093 into main Oct 15, 2026
25 checks passed
@thymikee
thymikee deleted the refactor/daemon-proxy-devdep branch October 15, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant