Repository navigation
chore(daemon): declare @agent-device/proxy as a devDependency - #3685
Merged
Merged
Conversation
Contributor
Size Report
Startup median (7 runs, lower is better):
|
Contributor
|
…only a test imports it Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
thymikee
force-pushed
the
refactor/daemon-proxy-devdep
branch
from
October 15, 2026 17:47
698b115 to
e04dc79
Compare
Member
Author
|
Moving I did not run The Smoke Tests are queued and have not failed. This change cannot alter any route they exercise. There are no conflicts. Once the queued checks finish green, this is ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up promised in #3638:
@agent-device/proxymoves fromdependenciestodevDependenciesinpackages/daemon/package.json, because onlyhttp-server-proxy.test.tsimports it. R11 accepts devDependencies for test-file imports since #3659. The lockfile moves the same entry from thedependenciesto thedevDependenciesblock of the daemon importer; no package version changes.Evidence
vi.mockto prove, and no moved file.daemonstays at 81 keys (80./testing/*plus.); no package gains a subpath, barrel orexport *.check:layeringpasses (R11 accepts the devDependency for the test import, and the project-reference check still matches the manifest);check:fallowandcheck:gate-manifestpass.check:quickfails onmainbefore this change too:packages/daemon/src/__tests__/support/command-surface-fake.tsand thesnapshot-freshness/wait-capture-optionstests no longer typecheck against refactor(capture): require complete runtime snapshots #3642's requiredsnapshot, which fix(test): migrate the daemon stack's tests to complete runtime snapshots #3684 fixes. This PR must not duplicate that fix; I rebase after fix(test): migrate the daemon stack's tests to complete runtime snapshots #3684 merges and the typecheck, unit and coverage checks go green with it.🤖 Generated with Claude Code