Repository navigation
refactor(test-kit): move the interaction-targeting node fixtures out of selectors - #3709
Conversation
… selectors Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rom test-kit Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Size Report
Startup median (7 runs, lower is better):
|
|
This PR is ready at 8084aa0. The move of the interaction-targeting node fixtures out of selectors looks correct. Not blocking: the description string in packages/selectors/package.json (line 7) now has a literal … where it had an escaped one, which is unrelated to the move, so you can revert that hunk or leave it. There are no conflicts. Smoke Tests is still running, and the other checks are not failing. The diff touches only test fixtures and package wiring, so I see no runtime route involved. I did not run the layering, fallow or ceiling gates or any tests. I also did not check whether the published package or build keeps test-kit out of the selectors production closure. Smoke Tests still needs to finish. |
What
The
interaction-targetingnode fixtures (nineRawSnapshotNode[]trees captured from live iOS and React Native snapshots) are used by selectors' own tests and by tests in replay-port and root. They were published from@agent-device/selectors/interaction-targeting-fixtures; they now live in@agent-device/test-kitas nine named exports.git mvofinteraction-targeting.fixtures.tsfrompackages/selectors/srctopackages/test-kit/src(the file imports only akerneltype, so it needs no edits).@agent-device/test-kit; selectors declares test-kit indevDependenciesand tsconfigreferences(test-kit no longer reaches selectors after refactor(test-kit): drop the daemon-contracts dependency #3686/refactor(test-kit): drop command-registry by making the replay-script generator a root fixture #3687, so no reference cycle); the./interaction-targeting-fixturesexport and its line in the layering test are removed; one duplicate test-kit import in replay-port's test is merged.Fixture decision
selectors/interaction-targeting-fixturestest-utils/index.ts,selector-action-resolution.test.ts)kerneltypesParity
vitest run <files> --reporter=json, origin/main against this branch, over the 4 direct importers plus every test that imports the roottest-utilshelper: 28 files, 265 / 265 -> 265 / 265. No test file moved;unit-coreselects them as before. Novi.mockinvolved.Surface
exports: selectors 18 -> 17 (./interaction-targeting-fixturesremoved); test-kit stays one"."entry, +9 named exports; no barrels orexport *. Selectors gains a test-kit devDependency + reference; the R83 isolation walk andtsc -bstay acyclic.Gates
check:quick,check:layering,check:fallow,check:gate-manifest,pnpm formatpass.check:affected --run(full set, since a package manifest changed) passes except one test,test/integration/smoke-web-platform.test.ts > web shutdown cleanup reaps the exact daemon that survived graceful shutdown. It fails identically on a cleanorigin/main(reproduced alone under the host lock on both), so it is a pre-existing, host-dependent failure unrelated to this diff.The gates ran on the pre-rebase head; after rebasing onto #3704 I re-ran lint, format, install and the 265-test parity set.
🤖 Generated with Claude Code