Skip to content

refactor(test-kit): move the interaction-targeting node fixtures out of selectors - #3709

Merged
thymikee merged 2 commits into
mainfrom
refactor/interaction-targeting-to-test-kit
Oct 16, 2026
Merged

thymikee merged 2 commits into
mainfrom
refactor/interaction-targeting-to-test-kit

Conversation

@thymikee

@thymikee thymikee commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

What

The interaction-targeting node fixtures (nine RawSnapshotNode[] trees captured from live iOS and React Native snapshots) are used by selectors' own tests and by tests in replay-port and root. They were published from @agent-device/selectors/interaction-targeting-fixtures; they now live in @agent-device/test-kit as nine named exports.

Fixture decision

Fixture Importers by package Outcome Reason
selectors/interaction-targeting-fixtures selectors 2 tests, replay-port 1, root src 2 (test-utils/index.ts, selector-action-resolution.test.ts) case 3: test-kit shared by three packages' tests; plain node data over kernel types

Parity

vitest run <files> --reporter=json, origin/main against this branch, over the 4 direct importers plus every test that imports the root test-utils helper: 28 files, 265 / 265 -> 265 / 265. No test file moved; unit-core selects them as before. No vi.mock involved.

Surface

exports: selectors 18 -> 17 (./interaction-targeting-fixtures removed); test-kit stays one "." entry, +9 named exports; no barrels or export *. Selectors gains a test-kit devDependency + reference; the R83 isolation walk and tsc -b stay acyclic.

Gates

check:quick, check:layering, check:fallow, check:gate-manifest, pnpm format pass. check:affected --run (full set, since a package manifest changed) passes except one test, test/integration/smoke-web-platform.test.ts > web shutdown cleanup reaps the exact daemon that survived graceful shutdown. It fails identically on a clean origin/main (reproduced alone under the host lock on both), so it is a pre-existing, host-dependent failure unrelated to this diff.

The gates ran on the pre-rebase head; after rebasing onto #3704 I re-ran lint, format, install and the 265-test parity set.

🤖 Generated with Claude Code

View guided diff Turn on auto-fix

thymikee and others added 2 commits October 16, 2026 13:10
… selectors

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rom test-kit

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-10-16 11:40 UTC

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 11 files

View guided diff | Turn on auto-fix | Re-trigger cubic

@github-actions

Copy link
Copy Markdown
Contributor

Size Report

Metric Base Current Diff
Installed (including dependencies) 5.29 MB 5.29 MB 0 B
Package (unpacked) 5.29 MB 5.29 MB 0 B
Package (download) 1.59 MB 1.59 MB +8 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 26.7 ms 26.5 ms -0.2 ms
CLI --help 77.6 ms 75.6 ms -2.0 ms

@thymikee

Copy link
Copy Markdown
Member Author

This PR is ready at 8084aa0. The move of the interaction-targeting node fixtures out of selectors looks correct. Not blocking: the description string in packages/selectors/package.json (line 7) now has a literal … where it had an escaped one, which is unrelated to the move, so you can revert that hunk or leave it. There are no conflicts. Smoke Tests is still running, and the other checks are not failing. The diff touches only test fixtures and package wiring, so I see no runtime route involved. I did not run the layering, fallow or ceiling gates or any tests. I also did not check whether the published package or build keeps test-kit out of the selectors production closure. Smoke Tests still needs to finish.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Oct 16, 2026
@thymikee
thymikee merged commit 179aced into main Oct 16, 2026
23 checks passed
@thymikee
thymikee deleted the refactor/interaction-targeting-to-test-kit branch October 16, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant