Repository navigation
Add basic conformance tests for the sets extension - #533
Merged
Merged
Conversation
l46kok
reviewed
Oct 21, 2026
l46kok
left a comment
l46kok
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, just some minor suggestions for more coverage
| expr: "sets.contains([{'a': 'b'}, {'c': 'd'}], [{'a': 'b'}])" | ||
| } | ||
| test: { | ||
| name: "maps_heterogeneous_numeric" |
Collaborator
There was a problem hiding this comment.
Could we also add a case for heterogeneous map keys?
Collaborator
Author
There was a problem hiding this comment.
added a basic one. there are some behavior inconsistencies when there's an equivalent uint and int so leaving that out for now.
| # Returns whether the first list argument (arg0) contains all elements in the | ||
| # second list argument (arg1), i.e., whether arg0 is a superset of arg1. | ||
| section: { | ||
| name: "contains" |
Collaborator
There was a problem hiding this comment.
Test cases that exercises the numeric boundaries would be nice (NaN, max int, max uint etc)
| test: { | ||
| name: "proto_messages" | ||
| container: "cel.expr.conformance.proto3" | ||
| expr: "sets.equivalent([TestAllTypes{single_int64: 1, single_uint64: 2u}, TestAllTypes{single_int64: 1, single_uint64: 2u}], [TestAllTypes{single_int64: 1, single_uint64: 2u}])" |
Collaborator
There was a problem hiding this comment.
Thoughts on adding wrappers? Just to make sure the WKT handling works as intended
sets.equivalent(
[TestAllTypes{single_int64_wrapper: 1}.single_int64_wrapper, TestAllTypes{}.single_int64_wrapper],
[null, 1u]
)
l46kok
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.