Repository navigation
Conversation
RecordPkgOperationInChroot() wrote the architecture before the version, the reverse of the order its readers expect. Ticket: none Changelog: Title Signed-off-by: Daniel JB Clark <djbclark@gmail.com> Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This was referenced Oct 9, 2026
|
Thank you for submitting a PR! Maybe @larsewi can review this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RecordPkgOperationInChroot()wrote a package's architecture before its version, the reverse of the order both readers expect, so--simulatereportedfoo-1.2.3 [x86_64]instead offoo-x86_64 [1.2.3]. The fix swaps the two writes and names the record format in a comment at the writer. One regression test, which fails without the fix:Ubuntu 24.04:
make -C tests/unit check→All 75 tests passed;tests/acceptance/29_simulate_mode/as root → 4 of 4 Pass. Fork CI: djbclark#39AI-assisted. I can't vouch for the C syntax beyond a basic level, but I did look at the logic and it seemed sound.
🤖 Generated with Claude Code