Skip to content

[TST]: Defer cross-version test collection - #7873

Merged
rescrv merged 1 commit into
mainfrom
rescrv/cvp-bug
Oct 9, 2026
Merged

rescrv merged 1 commit into
mainfrom
rescrv/cvp-bug

Conversation

@rescrv

@rescrv rescrv commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Description of changes

Move version discovery out of module import into
pytest_generate_tests so spawned writer children no longer
depend on a fresh PyPI request at startup.

Assert the writer process exits cleanly and close the
multiprocessing connections in a finally block so failures
surface instead of leaking resources.

Test plan

CI

Migration plan

N/A

Observability plan

N/A

Documentation Changes

N/A

Co-authored-by: AI

Move version discovery out of module import into
pytest_generate_tests so spawned writer children no longer
depend on a fresh PyPI request at startup.

Assert the writer process exits cleanly and close the
multiprocessing connections in a finally block so failures
surface instead of leaking resources.

Co-authored-by: AI

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@rescrv
rescrv merged commit 3d8bed7 into main Oct 9, 2026
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants