Skip to content

Fix stale Access application path parameter tests #2748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FranciscoMaxwell wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix stale Access application path parameter tests #2748

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 11 additions & 14 deletions tests/api_resources/zero_trust/access/test_applications.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,12 +210,11 @@ def test_path_params_create_overload_1(self, client: Cloudflare) -> None:
account_id="",
)

with pytest.raises(ValueError, match=r"You must provide either account_id or zone_id"):
client.zero_trust.access.applications.with_raw_response.create(
domain="test.example.com/admin",
type="self_hosted",
account_id="account_id",
)
client.zero_trust.access.applications.with_raw_response.create(
domain="test.example.com/admin",
type="self_hosted",
account_id="account_id",
)

@pytest.mark.skip(reason="TODO: investigate broken test")
@parametrize
Expand Down Expand Up @@ -3745,10 +3744,9 @@ def test_path_params_list(self, client: Cloudflare) -> None:
account_id="",
)

with pytest.raises(ValueError, match=r"You must provide either account_id or zone_id"):
client.zero_trust.access.applications.with_raw_response.list(
account_id="account_id",
)
client.zero_trust.access.applications.with_raw_response.list(
account_id="account_id",
)

@pytest.mark.skip(reason="TODO: investigate broken test")
@parametrize
Expand Down Expand Up @@ -7678,10 +7676,9 @@ async def test_path_params_list(self, async_client: AsyncCloudflare) -> None:
account_id="",
)

with pytest.raises(ValueError, match=r"You must provide either account_id or zone_id"):
await async_client.zero_trust.access.applications.with_raw_response.list(
account_id="account_id",
)
await async_client.zero_trust.access.applications.with_raw_response.list(
account_id="account_id",
)

@pytest.mark.skip(reason="TODO: investigate broken test")
@parametrize
Expand Down