Repository navigation
Improve test suite to avoid flaky container event order - #101
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The focused test changes address the event-order race with no blocking issues identified.
No open issues 🎉
What changed in this PR
Stabilizes the container lifecycle test by waiting for exit before attaching, removing the event-order race without changing the library.
Changes:
- Waits for container exit and verifies a zero exit status.
- Replaces version-dependent event expectations with one ordered sequence.
| File | Description |
|---|---|
| tests/FunctionalClientTest.php | Waits for exit before attaching and simplifies event assertions. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset improves the test suite to avoid a flaky container event order. The test container could still be running when the test attached to it, so the
dieandattachevents arrived in either order and failed 5 of the last 17 CI runs (counting reruns). The test now waits for the container to exit first, which also means it is never killed on removal, so the separate expectation for Docker before 20.10 (2020) is no longer needed. The race dates back to #61, the library itself is unchanged.Builds on top of #98, #80 and #61