Repository navigation
Conversation
carson-codeigniter4
Bot
added
the
bug
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Empty-value handling and mixed reporting modes can silently remove enforced security restrictions.
4 open issues
What changed in this PR
Normalizes Content Security Policy values to address keyword quoting, empty entries, and numeric-key type errors.
Changes:
- Splits configured strings and normalizes header keys.
- Adds regression tests for normalization and sandbox flags.
- Documents the fix in the changelog.
Base branch is unspecified; develop compatibility rules were assumed. Validation used targeted code inspection; automated tests remain for CI.
| File | Description |
|---|---|
| user_guide_src/source/changelogs/v4.7.6.rst | Documents the normalization fix. |
| tests/system/HTTP/ContentSecurityPolicyTest.php | Adds normalization regression tests. |
| system/HTTP/ContentSecurityPolicy.php | Changes option normalization and header generation. |
Review effort: Balanced
gr8man
force-pushed
the
fix/csp-add-option-string-conversion
branch
from
October 18, 2026 21:54
74c4afa to
6e01df9
Compare
This comment has been minimized.
This comment has been minimized.
gr8man
force-pushed
the
fix/csp-add-option-string-conversion
branch
from
October 18, 2026 21:57
6e01df9 to
607c93d
Compare
paulbalandan
changed the title
ContentSecurityPolicy::addOption()
carson-codeigniter4
Bot
added
the
github_actions
gr8man
force-pushed
the
fix/csp-add-option-string-conversion
branch
from
October 19, 2026 19:51
a37fe7c to
3fbbfb9
Compare
carson-codeigniter4
Bot
removed
the
github_actions
paulbalandan
left a comment
paulbalandan
left a comment
Member
There was a problem hiding this comment.
Please rebase to resolve conflicts
| is used instead. Values that cannot be converted to a string, such as objects | ||
| not implementing ``Stringable``, now throw a ``FormatException`` instead of a | ||
| fatal ``Error``. | ||
| - **HTTP:** Fixed a bug in ``ContentSecurityPolicy::addOption()`` where converting string directive values to array keys resulted in invalid entries for empty strings, unquoted values for space-separated lists, and ``TypeError`` for numeric strings. |
Member
There was a problem hiding this comment.
Nit: instead of describing the protected method's change, maybe describe more the user-facing change? Something like:
HTTP: Fixed a bug in ContentSecurityPolicy where a numeric source such as '0' threw a TypeError, and a space-separated directive string in Config\ContentSecurityPolicy was emitted as one unquoted source.
…tion() - Normalize space-separated and empty strings into array options via stringToOptions() - Cast numeric string array keys back to string to prevent TypeError under strict types - Preserve empty source lists as deny-all directives across all directives - Retain empty markers when other options move between reporting modes - Add comprehensive regression tests for config and runtime directives
gr8man
force-pushed
the
fix/csp-add-option-string-conversion
branch
from
October 23, 2026 19:10
3fbbfb9 to
66d0006
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed
ContentSecurityPolicy::addOption()andaddToHeader()converting string values directly into array keys, which created invalid entries for empty strings, prevented keyword quoting for space-separated lists, and caused a fatalTypeErrorin PHP 8 strict mode when numeric strings were converted to integer array keys.Checklist: