Repository navigation
fix: reject missing keys in CLI::promptByMultipleKeys() - #10654
Open
paulbalandan wants to merge 1 commit into
Open
paulbalandan wants to merge 1 commit into
paulbalandan wants to merge 1 commit into
Conversation
carson-codeigniter4
Bot
added
the
bug
michalsn
approved these changes
Oct 23, 2026
5 tasks done
paulbalandan
force-pushed
the
prompt-multiple-keys-missing-key
branch
from
October 23, 2026 10:47
861dc50 to
83e5eec
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CLI::promptByMultipleKeys()checked only that no chosen key was larger than the last key of the options, not that every chosen key exists. So:0and2, the answer1was accepted and returned an empty selection.0,5and2, the answer5was rejected.It now asks again unless every chosen key is one of the option keys. The body is also simplified into a single ask-and-check loop, with no change to what it prints or returns for valid answers.
Checklist: