Repository navigation
Web versions show the content that was sent - #121
Merged
Merged
Conversation
Each send stores (or reuses) an immutable copy of the email's subject and content, and its view-in-browser link carries that version's public id, so editing a running sequence's email no longer changes what earlier recipients and test links show. Older links keep showing current content. A sent broadcast's title (its subject) is now locked like its content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #120.
What
email_content_versionstable: one immutable row per distinct subject + content of an email (deduped by hash, publicver_id, deleted with the email).vclaim).email_deliveries.content_version_idrecords which version each contact got.GET /view/:tokenrenders the stored version; a version from another email returns 404. Links withoutv(sent before this) keep rendering current content.updateSequencerefuses to change a sent broadcast's title (its subject), matching the existing content lock.Why
Editing an active sequence's email changed what earlier recipients saw in their web version, and test links showed later draft edits.
Tests
Version dedupe and ownership, edit mid-sequence (earlier link shows A, later shows B), legacy links, foreign version 404, test link shows tested content, broadcast title lock.