Repository navigation
Pace only shared-mailbox sends; review a new account's first large own-ESP broadcast - #123
Merged
Merged
Conversation
…irst large own-ESP broadcast New-account pacing applied to every marketing send of a hosted organization, including sends through the team's own ESP, whose reputation and limits are the team's. Pacing now applies only to sends through a shared mailbox. Through the team's own ESP, a new account's first broadcast to FIRST_BROADCAST_REVIEW_RECIPIENTS (1000) or more contacts is held once for operator review (abuse flag kind broadcast). Closes #122
A team can put open, click, unsubscribe and view-in-browser links on its own subdomain. The domain is verified by its CNAME and an HTTPS probe, rechecked hourly while pending and daily once verified, and falls back to the API host after three failed daily checks. Retired domains keep being served so links in sent emails keep working. On a tracking domain only the tracking routes answer; /tls/ask lets an on-demand TLS proxy issue certificates for teams' domains. REST, MCP, dashboard card and docs included. The domain authentication dialog now names the bounce (Return-Path) domain in its SPF section. Closes #50
- A released large-import review also covers the account's first large own-ESP broadcast, so a new account is reviewed once, not twice. - Broadcasts, sequences, test sends and tracked transactional emails ask SendGrid (X-SMTPAPI filters), Mailgun and Postmark not to track opens and clicks SendLit already tracks, via a provider capability. - Self-hosting docs: which safeguards apply where, test-send and auto-pause settings, and the ESP tracking switches.
# Conflicts: # apps/api/.env.example # apps/api/src/automation/process-ongoing-sequence.ts # apps/api/src/mail/worker.ts # apps/api/src/sequences/test-send.ts # apps/docs/content/docs/self-hosting/meta.json
Nodemailer MIME-encoded the long JSON header, which SendGrid can't parse, so the tracking-off filters would have been ignored. Found in a smoke test.
Custom tracking domain per team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #122. Closes #50 (merged in via #124).
What
reserveSendapplies new-account hourly pacing only to outbound messages through a shared mailbox (delivery_source_type = organization), and counts only those sends against the hourly budget.broadcastPacingreports pacing only for such broadcasts.FIRST_BROADCAST_REVIEW_RECIPIENTS(default 1000) or more contacts is held once:startSequenceraises an abuse flag of the new kindbroadcast, emails the owners and returns 400broadcast_held_for_review. After an operator releases it (abuse.ts release), it and later broadcasts start normally. Exempt and established organizations and self-hosted installs are never held.abuse_flags_kind_checkto includebroadcast..env.exampleand operator CLI help updated.Not changed
The plan's new-account marketing ramp (
advanceMarketingRamp, 200/day at first on fair-use plans) still applies to every source; see the open question in #122.Tests
marketing_hourly_pacingat 17/hour; own-ESP sends don't.Also in this PR
ownTrackingOffHeaders): SendGridX-SMTPAPIclicktrack/opentrack filters,X-Mailgun-Track-Clicks/Opens: no,X-PM-TrackOpens: false/X-PM-TrackLinks: None. This covers broadcasts, sequences, test sends, and transactional emails for whichever of opens and clicks SendLit tracks. Resend and SES have no per-message switch; the docs say how to turn it off there.X-SMTPAPIJSON, which SendGrid can't parse.sendMailnow sends that header unencoded.self-hosting/sending-safeguardspage covers which safeguards apply on self-hosted vs Cloud, test-send and auto-pause settings, and the ESP tracking switches. The README and both.env.examplefiles are updated.Smoke tested on the stack
import_under_review. After release, the first broadcast held withbroadcast_held_for_review(before the one-review change). After release it started and reported no pacing.X-SMTPAPIfilters header.