Repository navigation
build(deps): batch Dependabot bumps (#101–#107) - #108
Conversation
|
@codex review |
|
@codex security review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Batches today's Dependabot Go-module bumps into a single PR, per the repo's dependency policy. None of them is a security fix: the repo has no open Dependabot alerts.
Bumps
state/redisgithub.com/alicebob/miniredis/v2state/redisgithub.com/redis/go-redis/v9examples/slack-redis-stategithub.com/redis/go-redis/v9state/natsgithub.com/nats-io/nats-server/v2Indirect changes that come with these bumps:
state/nats,state/postgres,state/redis,examples/slack-nats-stategithub.com/klauspost/compressstate/postgres,state/redisgithub.com/stretchr/testifystate/postgres,state/redisgopkg.in/yaml.v3v3.0.1 →go.yaml.in/yaml/v3v3.0.5state/redis,examples/slack-redis-statego.uber.org/atomicexamples/slack-postgres-state/go.sumchanges only because the state modules it uses changed. The go.mod and go.sum lines in this PR are exactly the union of the lines in #101–#107: no line is missing or extra, and no module version has a different hash.Changelog review
I read the upstream release notes for all three bumps. Nothing in them changes behavior for this repo. These are the items worth knowing:
go 1.26.0). Our modules already require 1.26.3.Clientnow has its own pipeline connection pool by default (PipelinePoolSize= 10). OnlyPipeline,TxPipelineand autopipeline calls use it.state/redismakes none of these calls outside its tests. A caller who passes their own client and pipelines on it can open up to 10 more connections.PipelinePoolSize: -1turns the pool off.ParseURLnow returns an error for a badskip_verifyvalue (for exampleskip_verify=yes). Before, it silently usedfalse.examples/slack-redis-stateparsesREDIS_URLwithParseURL, so such a URL now fails at startup.go vetpasses.state/nats/nats_test.goimports it, to run an embedded server. The release drops the legacy$GR.gateway reply prefix (servers older than v2.1.2) and contains JetStream, leafnode and auth fixes. None of these affect the embedded test server.state/redis/redis_test.goimports it. The release addstesting/synctestsupport and theZMPOP,BZMPOPandLMPOPcommands, and fixesRENAME,SetError,LPOS COUNTandHRANDFIELD.How it was produced
origin/mainat 3c26d1f.go getfor each bump in each affected module, with Go 1.27.1 (the mise pin): miniredis and go-redis instate/redis, go-redis inexamples/slack-redis-state, and nats-server instate/nats.go mod tidyin all 7 workspace modules, thengo work sync. Repeated until nothing changed (2 passes).go.mod/go.sumfiles change. The root module andgo.work.sumare untouched.Validation
mise run vet: pass.go.work.sumstayed unchanged.go test -racein every workspace module: pass. The state modules ran with-v(embedded NATS server, and Postgres and Redis through Testcontainers): postgres 5, redis 10, nats 6 tests passed, 0 skipped.GOWORK=off go build ./...instate/nats,state/postgresandstate/redis: pass.adapters/linearTestRateLimitDeadlineReturnsTypedRateLimited, failed once in the firstGOFLAGS=-race mise run testrun (context deadline exceeded). This PR does not change the root module's go.mod or go.sum. The test then passed 10 of 10 runs with-race -count=10, and the full root module passed with-race. I treat it as a timing flake on main.Batch policy
Bot PRs are not merged one by one. They go into one batch PR that passes the standard gate: green CI, clean Codex code and security reviews, no unresolved threads. Dependabot then closes its PRs by itself, because main satisfies them.
Closes #101
Closes #102
Closes #103
Closes #104
Closes #105
Closes #106
Closes #107
Generated with
xum• Model:anthropic:claude-opus-5-5• Thinking:high