Repository navigation
fix: forward OSC 52 copies to the browser clipboard - #8061
Open
yasir-erkam wants to merge 2 commits into
Open
yasir-erkam wants to merge 2 commits into
yasir-erkam wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OSC 52 copy requests from terminal applications can report success while leaving the browser clipboard unchanged. The terminal provider explicitly passes
clipboard, but BrowserClipboardService routes explicitly typed writes into an internal map instead of calling the browser clipboard API.Add a VS Code patch that uses the default clipboard destination for normal OSC 52 writes. PRIMARY selection and clipboard reads stay unchanged. This fixes copying in fullscreen CLI applications without changing their display settings.
Related upstream issue: microsoft/vscode#318254. Existing upstream fixes microsoft/vscode#318255 and microsoft/vscode#334287 remain open; this patch covers the write path while those fixes are pending.
Reproduce by seeding the clipboard, running this in the integrated terminal, then pasting into an editor:
Before: the previous clipboard value remains. After:
CLIPBOARD_TESTis pasted.Validation: