Repository navigation
ci: upgrade Node to fixed releases for CVE-2026-111497 - #209
Merged
Merged
Conversation
- Pin actions/setup-node in publish.yml to 24.22.1 (was EOL Node 20). - Bump the nixpkgs flake input so the dev shell and nix build get nodejs_22 22.23.4 (was 22.21.1). Change-Id: I53a5399896bbc3ccde77ec839f3404bff778d884 Signed-off-by: Thomas Kosiewski <tk@coder.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remediates Node2Shell (CVE-2026-111497) for ghostty-web, tracked in the "Phase 2 Node upgrades" Notion page.
Changes
.github/workflows/publish.yml: bothactions/setup-nodesteps now pin Node24.22.1. They used end-of-life Node20, which never gets the fix.flake.lock: bumps thenixpkgsinput from2d293cb(2025-11-30) to3ec6363(2026-10-23).pkgs.nodejs_22in the dev shell and inpackages.defaultgoes from22.21.1(vulnerable) to22.23.4(fixed). This also updates other nixpkgs tools, for examplebunto 1.4.2 in the nix shell. CI does not use the flake.ghostty-web is a library and is not deployed. Node only runs in CI to publish to npm, so no redeploy is needed.
Validation
bun run fmt && bun run lint && bun run typecheck && bun test && bun run build: pass (372 tests, built with Zig 0.15.2).actionlint .github/workflows/publish.yml: clean.node:24.22.1container:node -vprintsv24.22.1, andnpm install -g npm@latest(the publish job's next step) installs npm 12.2.1.nix eval --inputs-from . nixpkgs#nodejs_22.versionprints22.23.4. I built it andnode -vprintedv22.23.4.devShells.x86_64-linux.defaultandpackages.x86_64-linux.defaultboth evaluate.actions/node-versionshas a24.22.1entry, sosetup-nodecan resolve the pin.The publish workflow itself only runs on release, so this PR does not exercise it. The first release after merge will.
Generated with
xum• Model:anthropic:claude-opus-5-5• Thinking:high