Repository navigation
fix: repair fork CI and stop false-green test runs - #136
Merged
Merged
Conversation
EhabY
force-pushed
the
chore/repair-fork-ci
branch
from
October 14, 2026 11:29
3c86017 to
2e8d147
Compare
EhabY
added this pull request to stack #137
October 14, 2026 11:32
EhabY
force-pushed
the
chore/repair-fork-ci
branch
3 times, most recently
from
October 14, 2026 12:19
4701f15 to
ccf2c31
Compare
EhabY
removed this pull request from stack #137
October 14, 2026 13:47
EhabY
force-pushed
the
chore/repair-fork-ci
branch
2 times, most recently
from
October 14, 2026 19:50
51d6e5e to
eebe927
Compare
EhabY
force-pushed
the
chore/repair-fork-ci
branch
from
October 14, 2026 19:57
eebe927 to
a5ab5fa
Compare
EhabY
marked this pull request as ready for review
October 14, 2026 19:58
EhabY
force-pushed
the
chore/repair-fork-ci
branch
from
October 14, 2026 20:31
a5ab5fa to
828555c
Compare
Upgrade AWS S3 dependencies and Staticcheck so the fork builds, and refresh generated files and depaware inventories. Make testwrapper fail on build, setup, and package failures, including tests that time out without a final event, while still retrying marked flaky tests. Print each package result once, and keep timeout panics that go test attributes to an already-passed test. Run the Windows tests through testwrapper so marked flaky tests are retried there too. Fuzz this fork's own targets with ClusterFuzzLite instead of building upstream through OSS-Fuzz. Fix license headers and the empty-interval connstats assertion, upgrade artifact uploads, restrict job permissions, and allow the upstream-only VM job to be skipped.
EhabY
force-pushed
the
chore/repair-fork-ci
branch
from
October 14, 2026 21:02
828555c to
2594ccf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repair fork CI so it builds and tests this fork's own code, and stop the test wrapper from reporting failures as passes.
cmd/testwrapperfail on build, setup, and package failures, including tests that time out without a final event, while still retrying marked flaky tests. Each package result is printed once, and timeout panics are no longer dropped.cmd/testwrapperso marked flaky tests are retried there too.connstatsassertion, upgrade artifact uploads, restrict job permissions, and allow the upstream-onlyvmjob to be skipped.Decisions and validation
feature/s3/manageris only used by the upstream VM test, but upgrading it forcesaws-sdk-go-v2/configv1.18 → v1.32, whichipn/store/awsstoreuses at runtime. coder already builds withconfigv1.33.1, so its resolved version is unchanged.build.shcopiesGOROOTbecause the v2 fuzz builder patches testing internals and must match the declared Go toolchain.failevent that Go 1.24+ always emits, so there is no separatebuild-failhandling. The wrapper drops go test's ownok/FAIL/?lines for a package and prints its summary (with the attempt number) instead; other package output, such asinitpanics, is still printed.--- PASS/--- SKIPline instead of buffering it into logs that are never shown.go test, sonet/connstatsTestConcurrent(marked flaky, net/connstats: flake in TestConcurrent tailscale/tailscale#7030) failed 2 of the last 25 Windows jobs. It never needed a retry in 75 Linux test jobs, where the wrapper already retries marked tests. Like the Linuxbench allstep, Windows now prints benchmark results only when a benchmark fails.TestCLIruns the real wrapper against fixture modules that use the repo'sgoversion: pass, invalid flags, compile error, flaky retry, flaky plus compile error, non-flaky failure, timeout, timeout after a parallel pass (without-v, as CI runs), and flaky plus timeout. It also checks that each package result appears once. The flaky-plus-timeout, timeout-after-parallel-pass, and single-summary checks fail without their fixes.vmjob is skipped.Generated with Coder Agents on behalf of @EhabY.