Repository navigation
Clean up after installs and updates again - #147
Merged
Merged
Conversation
setup_uv cleaned its temp dir with trap ... EXIT, which replaced on_exit for the rest of every uv-based install and update. It now uses a RETURN trap, like the forge helpers.
lxc/install.func overrode cleanup_lxc with pkg_clean alone, so installs never cleared the uv, pip, npm, Go or cargo caches. core.func's cleanup_lxc now covers the other package managers through pkg_clean, and the override is gone. Most ct scripts exit inside update_script, so _cs_run_update never reached its cleanup_lxc. on_exit now runs it after a successful update.
Contributor
Try this branchThe engine and the scripts resolve independently, so a production script can COMMUNITY_SCRIPTS_CORE_URL=https://raw.githubusercontent.com/community-scripts/core/fix/install-cleanup-and-uv-trap \
bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/debian.sh)"Swap Run a script from a fork as wellcurl -fsSL https://raw.githubusercontent.com/community-scripts/core/fix/install-cleanup-and-uv-trap/tools/run.sh |
bash -s -- https://raw.githubusercontent.com/YOU/DevScripts/your-branch ct/debian.sh \
https://raw.githubusercontent.com/community-scripts/core/fix/install-cleanup-and-uv-trapNote that Useful flags while testing
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✍️ Description
lxc/install.func overrode cleanup_lxc with pkg_clean alone, so installs never cleared the uv, pip, npm, Go or cargo caches. core.func's cleanup_lxc now covers the other package managers through pkg_clean, and the override is gone.
setup_uv cleaned its temp dir with trap ... EXIT, which replaced on_exit for the rest of every uv-based install and update. It now uses a RETURN trap, like the forge helpers.
🔗 Related Issue
Fixes #
✅ Prerequisites (X in brackets)
API.txtwas updated to match.🤖 AI Assistance (X in brackets)
🛠️ Type of Change (X in brackets)
README,docs/,CONTRIBUTING.md, or other docs.