Skip to content

Clean up after installs and updates again - #147

Merged
MickLesk merged 2 commits into
mainfrom
fix/install-cleanup-and-uv-trap
Oct 16, 2026
Merged

MickLesk merged 2 commits into
mainfrom
fix/install-cleanup-and-uv-trap

Conversation

@MickLesk

Copy link
Copy Markdown
Member

✍️ Description

lxc/install.func overrode cleanup_lxc with pkg_clean alone, so installs never cleared the uv, pip, npm, Go or cargo caches. core.func's cleanup_lxc now covers the other package managers through pkg_clean, and the override is gone.

setup_uv cleaned its temp dir with trap ... EXIT, which replaced on_exit for the rest of every uv-based install and update. It now uses a RETURN trap, like the forge helpers.

🔗 Related Issue

Fixes #

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected (Proxmox VE and/or Incus, as applicable).
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.
  • API.txt regenerated – If a function signature or behavior changed, API.txt was updated to match.

🤖 AI Assistance (X in brackets)

If you used an AI tool (GitHub Copilot, Claude, ChatGPT, etc.) to write or generate any code in this PR, you must confirm compliance below.
Select exactly one option.

  • No AI used – Code was written without AI assistance.
  • AI was used – The output has been reviewed and corrected, and I take responsibility for it matching this repo's conventions.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing behavior in a way that may require updates in every downstream script.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, docs/, CONTRIBUTING.md, or other docs.

setup_uv cleaned its temp dir with trap ... EXIT, which replaced on_exit for the rest of every uv-based install and update. It now uses a RETURN trap, like the forge helpers.
lxc/install.func overrode cleanup_lxc with pkg_clean alone, so installs never cleared the uv, pip, npm, Go or cargo caches. core.func's cleanup_lxc now covers the other package managers through pkg_clean, and the override is gone.

Most ct scripts exit inside update_script, so _cs_run_update never reached its cleanup_lxc. on_exit now runs it after a successful update.
@github-actions

Copy link
Copy Markdown
Contributor

Try this branch

The engine and the scripts resolve independently, so a production script can
be run against the engine from this PR by setting one variable:

COMMUNITY_SCRIPTS_CORE_URL=https://raw.githubusercontent.com/community-scripts/core/fix/install-cleanup-and-uv-trap \
bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/debian.sh)"

Swap ct/debian.sh for whatever exercises the change.

Run a script from a fork as well
curl -fsSL https://raw.githubusercontent.com/community-scripts/core/fix/install-cleanup-and-uv-trap/tools/run.sh |
  bash -s -- https://raw.githubusercontent.com/YOU/DevScripts/your-branch ct/debian.sh \
             https://raw.githubusercontent.com/community-scripts/core/fix/install-cleanup-and-uv-trap

Note that run.sh is reached through a pipe, so the script it starts inherits
an exhausted stdin. Whiptail is fine — it opens /dev/tty — but a plain read
would see EOF. The single-variable form above does not have that problem.

Useful flags while testing

dev_mode=net logs every engine fetch with status and duration, which is the
quickest way to confirm the branch is really being used. dev_mode=keep stops a
failed build from deleting the container along with the evidence.

@MickLesk MickLesk changed the title Fix/install cleanup and uv trap Clean up after installs and updates again Oct 16, 2026
@MickLesk
MickLesk merged commit d228198 into main Oct 16, 2026
5 checks passed
@github-actions
github-actions Bot deleted the fix/install-cleanup-and-uv-trap branch October 17, 2026 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant