Repository navigation
test(Tooltip, Popover): timer specs check the directive's own show and hide timers - #326
Merged
Merged
Conversation
…d hide timers `vi.getTimerCount()` counted every pending fake timer, not only the directive's; one extra timer created during the test failed the show-timer spec on CI (its source was not measured). Show: the tooltip or popover element keeps `d-none` after destroy. Hide: destroy clears the 300 ms hide timer the directive scheduled. Dropping either `clearTimeout` in `destroyTooltipElement` fails its spec, also with a hide callback that tolerates a missing `tooltipRef`. `afterEach` restores spies before real timers, so a spy on a faked `setTimeout` is not put back after the clock is gone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vi.getTimerCount()counted every pending fake timer, not only the directive's; one extra timer created during the test failed the show-timer spec on CI (source not measured).Show: tooltip/popover element keeps
d-noneafter destroy. Hide: destroy clears the 300 ms hide timer the directive scheduled. Dropping eitherclearTimeoutindestroyTooltipElementfails its spec, also with a hide callback that tolerates a missingtooltipRef.afterEachrestores spies before real timers: in the other order thesetTimeoutspy put the faked function back after the clock was uninstalled, and toaster specs later in the same worker timed out.