Repository navigation
Use k8s-libsonnet 1.36 - #69
Merged
Merged
Conversation
k8s-libsonnet removed the 1.30 directory and keeps only 1.33 to 1.36. `tk init --k8s=1.30` still installs the repository, but github.com/jsonnet-libs/k8s-libsonnet/1.30/main.libsonnet no longer exists, so the README instructions and `make test-readme` fail with: couldn't open import "github.com/jsonnet-libs/k8s-libsonnet/1.30/main.libsonnet" Change the README and scripts/test-readme.sh to 1.36, the newest version. Signed-off-by: Friedrich Gonzalez <1517449+friedrichg@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Changes the README instructions and
scripts/test-readme.shfrom k8s-libsonnet 1.30 to 1.36.k8s-libsonnet removed the
1.30directory and now keeps only1.33to1.36.tk init --k8s=1.30still installs the repository, butgithub.com/jsonnet-libs/k8s-libsonnet/1.30/main.libsonnetno longer exists. So the README instructions and thereadmeCI job fail onmainwith:Checks, in
quay.io/cortexproject/cortex-jsonnet-build-image:fbe4726, the image that CI uses:make test-readme/s3,make test-readme/azureandmake test-readme/gcspass.test-readme/s3fails with the error above.Checklist
CHANGELOG.mdupdated