Repository navigation
Preserve Pandas 3 null-object semantics in P2P shuffle - #9381
Open
GeorgiaPreda wants to merge 1 commit into
Open
GeorgiaPreda wants to merge 1 commit into
GeorgiaPreda wants to merge 1 commit into
Conversation
Signed-off-by: GeorgiaPreda <23059939+GeorgiaPreda@users.noreply.github.com>
GeorgiaPreda
marked this pull request as ready for review
October 26, 2026 00:40
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 40 files ± 0 40 suites ±0 14h 9m 58s ⏱️ + 17m 31s For more details on these failures, see this check. Results for commit 21c444f. ± Comparison against base commit dc182bd. This pull request removes 1 and adds 44 tests. Note that renamed tests count towards both. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! I have an RFC for #9184.
Summary
Pandas 3 retains object dtype when concatenating an all-null object column with a typed column. P2P shuffle instead promotes Arrow's null type to the typed column, losing that distinction and replacing original null sentinels.
Implementation and tradeoff
Validation
python -m pytest distributed/shuffle/tests/test_shuffle.py distributed/shuffle/tests/test_merge.py -k "(null_partitions or null_object_column or processing_chain or split_by_worker or split_by_partition or basic_integration or handle_object_columns or stable_ordering or basic_merge or merge_by_multiple_columns) and not local_cluster"