Repository navigation
ENH: Adding MLX - #1008
Open
prady0t wants to merge 8 commits into
Open
ENH: Adding MLX#1008prady0t wants to merge 8 commits into
prady0t wants to merge 8 commits into
Conversation
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
prady0t
commented
Oct 4, 2026
Comment on lines
+78
to
+87
| class _MLXNamespaceInfo: | ||
| def __init__(self, info: object) -> None: | ||
| self._info = info | ||
|
|
||
| def __getattr__(self, name: str) -> object: | ||
| return getattr(self._info, name) | ||
|
|
||
| def default_dtypes(self, *, device: object = None) -> object: | ||
| _ = device | ||
| return self._info.default_dtypes() # type: ignore[attr-defined] |
Contributor
Author
There was a problem hiding this comment.
Most of the changes in these files should be in array-api-compat
prady0t
commented
Oct 4, 2026
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
prady0t
marked this pull request as ready for review
October 21, 2026 08:26
Contributor
Author
|
@lucascolley @ev-br Would love some reviews. The gigantic diff is mostly from the pixi lock file. |
Member
|
For me, a description would be helpful. What is the goal and what is the plan towards it? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue
Closes #1006
What does this implement/fix?
Additional information
AI Generation Disclosure
GitHub Copilot was used to generate changes in
_compat.pyfile