Repository navigation
guava fixes #683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
guava fixes #683
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -85,7 +85,7 @@ | |
| <dependency> | ||
| <groupId>com.google.guava</groupId> | ||
| <artifactId>guava</artifactId> | ||
| <version>31.0.1-jre</version> | ||
| <version>${guava.version}</version> | ||
| </dependency> | ||
|
Comment on lines
85
to
89
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The version of |
||
| <!-- test dependencies --> | ||
| <dependency> | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -79,7 +79,7 @@ | |||||
| <!-- version properties --> | ||||||
| <cdap.version>6.11.0</cdap.version> | ||||||
| <cdap.plugin.version>2.13.1</cdap.plugin.version> | ||||||
| <guava.version>13.0.1</guava.version> | ||||||
| <guava.version>32.0.0-jre</guava.version> | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Guava version
Suggested change
|
||||||
| <hadoop.version>3.3.6</hadoop.version> | ||||||
| <hsql.version>2.2.4</hsql.version> | ||||||
| <junit.version>4.13</junit.version> | ||||||
|
|
@@ -613,7 +613,7 @@ | |||||
| <properties> | ||||||
| <testSourceLocation>src/e2e-test/java</testSourceLocation> | ||||||
| <TEST_RUNNER>TestRunner.java</TEST_RUNNER> | ||||||
| <guava.version>32.1.2-jre</guava.version> | ||||||
| <guava.version>32.0.0-jre</guava.version> | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||||||
| </properties> | ||||||
| <build> | ||||||
| <testResources> | ||||||
|
|
@@ -713,7 +713,7 @@ | |||||
| <dependency> | ||||||
| <groupId>com.google.guava</groupId> | ||||||
| <artifactId>guava</artifactId> | ||||||
| <version>31.1-jre</version> | ||||||
| <version>${guava.version}</version> | ||||||
| </dependency> | ||||||
| </dependencies> | ||||||
| </dependencyManagement> | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version of
com.google.guava:guavais already managed in the parent POM's<dependencyManagement>section. Specifying the version here is redundant and can be safely removed to simplify dependency management.